qa: switch to https protocol for the repo server #49021

lxbsz · 2022-11-23T05:29:02Z

Since the git:// is not reachable any more and have switch to https://.

The git archive does not support the https protocol, so we couldn't user the git archive to retrieve the tar ball any more.

Fixes: https://tracker.ceph.com/issues/58290
Signed-off-by: Xiubo Li xiubli@redhat.com

Contribution Guidelines

To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows

qa/tasks/restart.py

mchangir

Could we have an array of git protocols in one place and use those to iterate over instead of manual changes all over the place ? Or is this a too naive approach ?

lxbsz · 2022-11-23T10:49:37Z

Could we have an array of git protocols in one place and use those to iterate over instead of manual changes all over the place ? Or is this a too naive approach ?

The git://git.ceph.com doesn't exist any more. If that's also true in future. IMO iterating this makes no sense.

qa/tasks/cephfs/xfstests_dev.py

qa/tasks/restart.py

github-actions · 2022-12-06T06:20:51Z

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

vshankar · 2022-12-08T13:23:58Z

jenkins retest this please

vshankar · 2022-12-08T13:24:01Z

https://tracker.ceph.com/projects/cephfs/wiki/Main#08-Dec-2022

qa/workunits/suites/fsx.sh

vshankar · 2022-12-12T04:44:52Z

qa/workunits/suites/fsx.sh

@@ -2,7 +2,7 @@

 set -e

-git clone git://git.ceph.com/xfstests.git
+git clone https://git.ceph.com/xfstests-dev.git
 cd xfstests


cd xfstests-dev

Fixed it. Thanks.

Need to do the same in qa/run_xfstests-obsolete.sh (install_xfstests function).

@idryomov This change has passed test - can we do your suggested change in another fix pls?

The reason it passed is that qa/run_xfstests-obsolete.sh is only used by RBD. If this was intended to be a CephFS-only PR, then just drop the change to qa/run_xfstests-obsolete.sh. I'll fix it myself (there is likely more to it then just cd xfstests-dev) and I'd like to avoid an inter-dependency between PRs when backporting.

What's the ptl-tool ?

src/script/ptl-tool.py

Fixed the os issue.

So it sounds like even your CephFS-only test wasn't complete enough...

I wonder where is restart.py being used. I do not see the task as part of fs suite run...

qa/suites/marginal/mds_restart/tasks/restart-workunit-backtraces.yaml ?

qa/suites/marginal/mds_restart/tasks/restart-workunit-backtraces.yaml ?

Sure. But what is marginal? I don't seem to running that. @batrick ?

* refs/pull/49021/head: qa: switch to https protocol for repos' server Reviewed-by: Rishabh Dave <ridave@redhat.com> Reviewed-by: Dhairya Parmar <dparmar@redhat.com>

vshankar · 2022-12-12T09:12:15Z

jenkins retest this please

Since the git:// is not reachable any more and have switch to https://. The git archive does not support the https protocol, so we couldn't user the git archive to retrieve the tar ball any more, will split this into 3 steps: 1, clone the whole ceph repo 2, checkout the commit/tag/branch 3, then change directory to qa/workunits/. Signed-off-by: Xiubo Li <xiubli@redhat.com>

vshankar · 2022-12-14T14:12:22Z

jenkins test make check

qa/tasks/restart.py

badone · 2022-12-15T22:30:36Z

Why no tracker for this? Do we have plans to backport this to quincy and pacific as they are both affected?

lxbsz · 2022-12-16T01:15:13Z

Why no tracker for this? Do we have plans to backport this to quincy and pacific as they are both affected?

Created one and will backport this.

badone · 2022-12-22T19:39:56Z

@lxbsz Thanks very much.

lxbsz requested a review from a team as a code owner November 23, 2022 05:29

github-actions bot added cephfs Ceph File System tests labels Nov 23, 2022

lxbsz requested review from a team, ljflores, zmc, gregsfortytwo and vshankar November 23, 2022 05:29

lxbsz force-pushed the git_https branch from 42c3adb to 8391680 Compare November 23, 2022 07:02

lxbsz changed the title ~~qa: switch git:// to https://~~ [RFC] qa: switch git:// to https:// Nov 23, 2022

lxbsz commented Nov 23, 2022

View reviewed changes

qa/tasks/restart.py Outdated Show resolved Hide resolved

mchangir reviewed Nov 23, 2022

View reviewed changes

lxbsz mentioned this pull request Nov 23, 2022

qa: cephfs add fscrypt test suite support for kclient #48628

Merged

14 tasks

lxbsz changed the title ~~[RFC] qa: switch git:// to https://~~ [RFC] qa: switch to https protocol for the repo server Nov 24, 2022

lxbsz force-pushed the git_https branch from 8391680 to 4c34a18 Compare November 24, 2022 05:45

lxbsz changed the title ~~[RFC] qa: switch to https protocol for the repo server~~ qa: switch to https protocol for the repo server Nov 24, 2022

lxbsz force-pushed the git_https branch from 4c34a18 to 8e00e03 Compare November 24, 2022 05:51

rishabh-d-dave approved these changes Nov 29, 2022

View reviewed changes

qa/tasks/cephfs/xfstests_dev.py Outdated Show resolved Hide resolved

qa/tasks/restart.py Outdated Show resolved Hide resolved

qa/tasks/restart.py Outdated Show resolved Hide resolved

vshankar added the wip-vshankar-testing label Dec 1, 2022

github-actions bot added the needs-rebase label Dec 6, 2022

lxbsz force-pushed the git_https branch from 8e00e03 to a9bb655 Compare December 6, 2022 06:55

github-actions bot removed the needs-rebase label Dec 6, 2022

lxbsz force-pushed the git_https branch from a9bb655 to 4fcd752 Compare December 6, 2022 07:00

dparmar18 approved these changes Dec 8, 2022

View reviewed changes

idryomov reviewed Dec 8, 2022

View reviewed changes

qa/workunits/suites/fsx.sh Outdated Show resolved Hide resolved

lxbsz force-pushed the git_https branch from 4fcd752 to 8561264 Compare December 9, 2022 01:47

vshankar requested changes Dec 12, 2022

View reviewed changes

lxbsz force-pushed the git_https branch from 8561264 to 1d8b179 Compare December 12, 2022 04:48

vshankar approved these changes Dec 12, 2022

View reviewed changes

lxbsz force-pushed the git_https branch 2 times, most recently from be0484c to 7ea891e Compare December 12, 2022 11:29

lxbsz force-pushed the git_https branch from 7ea891e to 89177d6 Compare December 12, 2022 13:06

vshankar removed the wip-vshankar-testing label Dec 12, 2022

vshankar reviewed Dec 15, 2022

View reviewed changes

qa/tasks/restart.py Show resolved Hide resolved

vshankar merged commit b2cd0fe into ceph:main Dec 15, 2022

This was referenced Dec 16, 2022

pacific: qa: switch to https protocol for repos' server #49470

Merged

quincy: qa: switch to https protocol for repos' server #49471

Merged

octopus: qa: switch to https protocol for repos' server #49472

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

qa: switch to https protocol for the repo server #49021

qa: switch to https protocol for the repo server #49021

lxbsz commented Nov 23, 2022 •

edited

mchangir left a comment

lxbsz commented Nov 23, 2022

github-actions bot commented Dec 6, 2022

vshankar commented Dec 8, 2022

vshankar commented Dec 8, 2022

vshankar Dec 12, 2022

lxbsz Dec 12, 2022

idryomov Dec 12, 2022

vshankar Dec 12, 2022

idryomov Dec 12, 2022 •

edited

vshankar Dec 12, 2022

lxbsz Dec 12, 2022 •

edited

vshankar Dec 12, 2022

lxbsz Dec 12, 2022

vshankar Dec 12, 2022

vshankar commented Dec 12, 2022

vshankar commented Dec 14, 2022

badone commented Dec 15, 2022

lxbsz commented Dec 16, 2022

badone commented Dec 22, 2022

qa: switch to https protocol for the repo server #49021

qa: switch to https protocol for the repo server #49021

Conversation

lxbsz commented Nov 23, 2022 • edited

Contribution Guidelines

Checklist

mchangir left a comment

Choose a reason for hiding this comment

lxbsz commented Nov 23, 2022

github-actions bot commented Dec 6, 2022

vshankar commented Dec 8, 2022

vshankar commented Dec 8, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

idryomov Dec 12, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lxbsz Dec 12, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vshankar commented Dec 12, 2022

vshankar commented Dec 14, 2022

badone commented Dec 15, 2022

lxbsz commented Dec 16, 2022

badone commented Dec 22, 2022

lxbsz commented Nov 23, 2022 •

edited

idryomov Dec 12, 2022 •

edited

lxbsz Dec 12, 2022 •

edited