Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pacific: Revert mon/OSDMonitor: Added extra check before mon.go_recovery_stretch_mode() #49412

Merged
merged 2 commits into from Dec 14, 2022

Conversation

kamoltat
Copy link
Member

@kamoltat kamoltat commented Dec 13, 2022

PR #48803 introduces
a regression found only in the Pacific branch resulting in
the following issue: https://tracker.ceph.com/issues/58239

Reverting the following commits from the Pacific branch:

94dc970
025d3fa

Fixes: https://tracker.ceph.com/issues/58239

Signed-off-by: Kamoltat ksirivad@redhat.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

…tch_mode()"

This commit belongs to ceph#48803 which
introduced https://tracker.ceph.com/issues/58239.
Therefore, we are reverting it.

This reverts commit 94dc970.

Fixes: https://tracker.ceph.com/issues/58239

Signed-off-by: Kamoltat <ksirivad@redhat.com>
This commit belongs to ceph#48803 which
introduced https://tracker.ceph.com/issues/58239.
Therefore, we are reverting it.

This reverts commit 025d3fa.

Fixes: https://tracker.ceph.com/issues/58239

Signed-off-by: Kamoltat <ksirivad@redhat.com>
@kamoltat kamoltat added this to the pacific milestone Dec 13, 2022
@kamoltat kamoltat self-assigned this Dec 13, 2022
@kamoltat kamoltat requested a review from a team as a code owner December 13, 2022 14:48
@kamoltat kamoltat changed the title Pacific Revert PR 48803 Pacific: revert mon/OSDMonitor: Added extra check before mon.go_recovery_stretch_mode() Dec 13, 2022
@kamoltat kamoltat changed the title Pacific: revert mon/OSDMonitor: Added extra check before mon.go_recovery_stretch_mode() Revert mon/OSDMonitor: Added extra check before mon.go_recovery_stretch_mode() Dec 13, 2022
@kamoltat
Copy link
Member Author

jenkins test signed

@kamoltat
Copy link
Member Author

jenkins test docs

@kamoltat
Copy link
Member Author

jenkins render docs

@ljflores ljflores changed the title Revert mon/OSDMonitor: Added extra check before mon.go_recovery_stretch_mode() pacific: Revert mon/OSDMonitor: Added extra check before mon.go_recovery_stretch_mode() Dec 14, 2022
@ljflores ljflores merged commit 48e909c into ceph:pacific Dec 14, 2022
@ljflores
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants