mds: force replay sessionmap version #49970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test make check |
vshankar
reviewed
Feb 6, 2023
dparmar18
reviewed
Feb 13, 2023
dparmar18
reviewed
Feb 13, 2023
|
@lxbsz I would also like to suggest this commit message as i feel the current one needs some corrections: |
When expiring the MDLog Segments it will persist the sessionmap, but in case the number of Segments doesn't reach up to the max segment threshold then the expiry may not happen. So if there is a MDS failover then the sessionmap won't be persistent and cannot be replayed by the standby MDS when it is starting. We should just force replay the sessionmap version just the way inotable does. Fixes: https://tracker.ceph.com/issues/58489 Signed-off-by: Xiubo Li <xiubli@redhat.com>
@kotreshhr They should be the same issue IMO. |
vshankar
added
the
wip-vshankar-backlog
vshankar
added
wip-vshankar-testing1
and removed
wip-vshankar-backlog
|
jenkins test api |
vshankar
added a commit
to vshankar/ceph
that referenced
this pull request
Mar 13, 2023
* refs/pull/49970/head: mds: force replay sessionmap version
This was referenced Mar 29, 2023
14 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When expiring the MDLog Segments will it persist the sessionmap, but what if the number of Segments doesn't reach up to the max segment threshhold the expiring may won't happen.
So if the MDS failover then the sessionmap won't be persist and couldn't be replayed by the standby MDS when it starting. We should just force replay the sessionmap version just the inotable does.
Fixes: https://tracker.ceph.com/issues/58489
Signed-off-by: Xiubo Li xiubli@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows