rgw: catches nobjects_begin() exceptions #50016
Conversation
max-licc
force-pushed
the
nobjects_begin_crash
branch
from
a7ee523
to
84113bb
Compare
|
@max-licc thanks for the contribution! i've updated https://tracker.ceph.com/issues/54802 which tracks this crash i see that the Signed-off-by check is failing. could you please update your commit messages to use the format it expects? |
| return 0; | ||
| } catch (const std::system_error& e) { | ||
| r = -e.code().value(); | ||
| ldpp_dout(dpp, 10) << "nobjects_begin threw " << e.what() |
There was a problem hiding this comment.
is 10 the right log level for this kind of error?
There was a problem hiding this comment.
i think 10 is a good choice. if this ends up being a fatal error, we should already be logging that at level 0 or 1 further up the call stack
There was a problem hiding this comment.
will we have more than an error code at that point in the unwind?
Signed-off-by: lichaochao <lichaochao2_yewu@cmss.chinamobile.com>
…exceptions Signed-off-by: lichaochao <lichaochao2_yewu@cmss.chinamobile.com>
max-licc
force-pushed
the
nobjects_begin_crash
branch
from
84113bb
to
63c7d2a
Compare
Thank you for your review. I have fixed it. |
|
jenkins test make check |
|
This passed my QA run and I'm waiting for @max-licc : would you be so kind as to fill in the checklist above and determine whether any backports are needed and if so create an appropriate tracker? Thank you! |
ivancich
added
bug-fix
and removed
wip-eric-testing-1
The problem of nobjects_begin() crash occurred in the test environment.
in RGWSI_RADOS::Pool::List::init() and log_list_init() , catch exceptions thrown by nobjects_begin().
Signed-off-by: lichaochao2_yewu@cmss.chinamobile.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows