cephfs_mirror: correctly set top level dir permissions #50049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchangir
force-pushed
the
cephfs_mirror-correctly-set-top-level-dir-permissions
branch
3 times, most recently
from
881096d
to
0f6d6b1
Compare
|
Teuthology job with the new integration test. |
vshankar
reviewed
Feb 16, 2023
| << cpp_strerror(r) << dendl; | ||
| return r; | ||
| } | ||
| r = ceph_fchmod(m_remote_mount, fh.r_fd_dir_root, tstx.stx_mode); |
There was a problem hiding this comment.
Why not do this when creating the directory structure in PeerReplayer::try_lock_directory()?
There was a problem hiding this comment.
mostly because this has nothing to do with directory locking
There was a problem hiding this comment.
True, but that's when the remote directory is created, and it makes sense to fix the perms at that point.
There was a problem hiding this comment.
What if the top-level dir permissions change over time ?
There was a problem hiding this comment.
Good question. What if the mirror daemon could just adjust the permissions after it acquired the remote lock on the directory?
mchangir
force-pushed
the
cephfs_mirror-correctly-set-top-level-dir-permissions
branch
5 times, most recently
from
c80a56e
to
8e2baf3
Compare
|
Teuthology Job: successful |
dparmar18
reviewed
Mar 6, 2023
dparmar18
reviewed
Mar 6, 2023
dparmar18
reviewed
Mar 6, 2023
mchangir
force-pushed
the
cephfs_mirror-correctly-set-top-level-dir-permissions
branch
from
8e2baf3
to
9f0c444
Compare
|
jenkins test make check arm64 |
dparmar18
reviewed
Mar 7, 2023
dparmar18
reviewed
Mar 7, 2023
Fixes: https://tracker.ceph.com/issues/58678 Signed-off-by: Milind Changire <mchangir@redhat.com>
Signed-off-by: Milind Changire <mchangir@redhat.com>
mchangir
force-pushed
the
cephfs_mirror-correctly-set-top-level-dir-permissions
branch
from
9f0c444
to
7849939
Compare
vshankar
approved these changes
Mar 8, 2023
vshankar
added a commit
to vshankar/ceph
that referenced
this pull request
Mar 13, 2023
* refs/pull/50049/head: qa: add cephfs_mirror test case to check root dir modes cephfs_mirror: sync snap dir root mode with remote dir Reviewed-by: Dhairya Parmar <dparmar@redhat.com> Reviewed-by: Venky Shankar <vshankar@redhat.com>
This was referenced Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/58678
Signed-off-by: Milind Changire mchangir@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows