Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github: add rgw team to CODEOWNERS #50073

Merged
merged 2 commits into from Feb 13, 2023
Merged

github: add rgw team to CODEOWNERS #50073

merged 2 commits into from Feb 13, 2023
+47 −2

Conversation

cbodley
Copy link
Contributor

@cbodley cbodley commented Feb 10, 2023

update CODEOWNERS for new team https://github.com/orgs/ceph/teams/rgw

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@cbodley
github: add rgw team to CODEOWNERS
41c3975 
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@github-actions github-actions bot added the CI Continuous Integration label Feb 10, 2023
@cbodley cbodley requested a review from a team February 10, 2023 18:25
@mattbenjamin
Copy link
Contributor

this interface is new to me, but looks good

mattbenjamin
mattbenjamin reviewed Feb 10, 2023
View reviewed changes
Copy link
Contributor

@mattbenjamin mattbenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good?

@cbodley
Copy link
Contributor Author

cbodley commented Feb 10, 2023

✅ This CODEOWNERS file is valid.

according to https://github.com/ceph/ceph/pull/50073/files

@yuvalif
Copy link
Contributor

yuvalif commented Feb 12, 2023

can we add ownership to /examples?

@cbodley
github: add /examples to CODEOWNERS
78c3839 
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley
Copy link
Contributor Author

cbodley commented Feb 13, 2023

@mattbenjamin @yuvalif kindly requesting your review/approval

@yuvalif yuvalif self-requested a review February 13, 2023 15:37
@cbodley cbodley merged commit a9cbbba into ceph:main Feb 13, 2023
@cbodley cbodley deleted the wip-codeowners-rgw branch February 13, 2023 15:53
@cbodley cbodley mentioned this pull request Feb 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattbenjamin mattbenjamin mattbenjamin left review comments

@idryomov idryomov idryomov left review comments

@yuvalif yuvalif yuvalif approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration
Projects
None yet
Milestone
No milestone
4 participants
@cbodley @mattbenjamin @yuvalif @idryomov