rgw: catch manifest decode errors in GetObj #50172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuvalif
reviewed
Feb 20, 2023
| bufferlist manifest_bl = s->attrset[RGW_ATTR_MANIFEST]; | ||
| if (manifest_bl.length()) { | ||
| if (iter = s->attrset.find(RGW_ATTR_MANIFEST); iter != s->attrset.end()) { | ||
| bufferlist manifest_bl = iter->second; |
There was a problem hiding this comment.
why not const bufferlist& here as well?
There was a problem hiding this comment.
the call to generate_fake_tag() takes this as a mutable reference
yuvalif
reviewed
Feb 20, 2023
|
i see there are similar decodes in RGWPutObj and RGWCopyObj that also need to be addressed |
if we read an object that doesn't have a manifest attribute, RGWRados::get_obj_state_impl() adds an empty one and causes decode to throw an end_of_buffer exception Fixes: https://tracker.ceph.com/issues/58794 Signed-off-by: Casey Bodley <cbodley@redhat.com>
better to tell the s3 client why their request failed than to log it as an ERROR; this is normal/expected when cloud tiering is enabled Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
soumyakoduri
approved these changes
Feb 21, 2023
yuvalif
approved these changes
Feb 21, 2023
14 tasks
|
jenkins test make check |
This was referenced May 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/58794
this catches exceptions on decode to avoid crashing, but also fixes several cases in RGWRados where we accidentally create empty attributes with the [] operator
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows