Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qa: make the xfstests tmp directories to be readable and excutable #50217

Merged
merged 2 commits into from Mar 2, 2023
Merged

qa: make the xfstests tmp directories to be readable and excutable #50217

merged 2 commits into from Mar 2, 2023

Conversation

lxbsz
Copy link
Member

@lxbsz lxbsz commented Feb 23, 2023

The user namespace test case will excute some commands as the other user. And the temporary direcotry have now the rx permission for other users by default and then will fail the tests.

This will chmod by making it to be readable and excutable.

Fixes: https://tracker.ceph.com/issues/58760

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@lxbsz lxbsz requested a review from a team February 23, 2023 03:23
@github-actions github-actions bot added cephfs Ceph File System tests labels Feb 23, 2023
@lxbsz lxbsz changed the title qa: make the xfstests tmp directoris to be readable and excutable qa: make the xfstests tmp directories to be readable and excutable Feb 23, 2023
@lxbsz
Copy link
Member Author

lxbsz commented Feb 23, 2023 •
edited

Both the relevant qa acls tests and qa fscrypt tests are running.

@lxbsz
Copy link
Member Author

lxbsz commented Feb 23, 2023

Both the relevant qa acls tests and qa fscrypt tests are running.

Both passed.

@lxbsz
Copy link
Member Author

lxbsz commented Feb 23, 2023

Only updated the commit comment since last tests.

@lxbsz
Copy link
Member Author

lxbsz commented Feb 23, 2023

Only updated the comments in code since last tests.

rishabh-d-dave
rishabh-d-dave approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@rishabh-d-dave rishabh-d-dave left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also suggest some improvements to the commit message -

The user namespace test case will execute some commands as the other
user. The temporary directory now has the rx permission for
other users by default. The tests then will fail otherwise.

Add back the generic/317 test.

Copying old commit message here for reference -

The user namespace test case will excute some commands as the other
user. And the temporary direcotry have now the rx permission for
other users by default and then will fail the tests.

This will chmod by making it to be readable and excutable.

qa/tasks/cephfs/xfstests_dev.py Show resolved Hide resolved
@lxbsz
Copy link
Member Author

lxbsz commented Feb 27, 2023

jenkins test make check

1 similar comment
@vshankar
Copy link
Contributor

jenkins test make check

@lxbsz
Copy link
Member Author

lxbsz commented Feb 27, 2023

jenkins test make check

The make check failure was newly introduced and has been fixed in #50268.

@dparmar18
Copy link
Contributor

jenkins test make check

The make check failure was newly introduced and has been fixed in #50268.

without that patch, this PR would still fail at make check, maybe merge both PRs?

@lxbsz
Copy link
Member Author

lxbsz commented Feb 27, 2023 •
edited

jenkins test make check

The make check failure was newly introduced and has been fixed in #50268.

without that patch, this PR would still fail at make check, maybe merge both PRs?

Yeah, sounds good to me. But need @vshankar to approve it.

@vshankar
Copy link
Contributor

jenkins test make check

The make check failure was newly introduced and has been fixed in #50268.

Which commit introduced the failure?

@lxbsz
Copy link
Member Author

lxbsz commented Feb 27, 2023 •
edited

jenkins test make check

The make check failure was newly introduced and has been fixed in #50268.

Which commit introduced the failure?

This PR #45669, before why that PR didn't fail it should be the ext_num_fwd and ext_num_retry in head were initialized as 0 randomly in the readable.sh test case.

@lxbsz
qa: make the xfstests tmp directories to be readable and excutable
8852b4d 
The user namespace test case will excute some commands as the other
user. And the temporary direcotry now has the rx permission for
other users by default. The test then will fail otherwise.

Fixes: https://tracker.ceph.com/issues/58760
Signed-off-by: Xiubo Li <xiubli@redhat.com>
@lxbsz
qa: enable the xfstests generic/317 test case
b150aec 
Since the permission denied bug has been fixed, just add the 317
test back.

Fixes: https://tracker.ceph.com/issues/58760
Signed-off-by: Xiubo Li <xiubli@redhat.com>
@lxbsz
Copy link
Member Author

lxbsz commented Feb 28, 2023

Rebased it.

@vshankar vshankar merged commit 1426cdf into ceph:main Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabh-d-dave rishabh-d-dave rishabh-d-dave approved these changes

@dparmar18 dparmar18 dparmar18 approved these changes

Assignees
No one assigned
Labels
cephfs Ceph File System tests
Projects
None yet
Milestone
No milestone
4 participants
@lxbsz @vshankar @dparmar18 @rishabh-d-dave