doc/rgw: improve diagram caption #50316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is a sequel to #50276. |
zdover23
force-pushed
the
wip-doc-2023-03-01-radosgw-multisite-diagram-object-replication-text-revision
branch
from
c508a71
to
51b8a03
Compare
anthonyeleven
approved these changes
Mar 1, 2023
doc/radosgw/multisite.rst
Outdated
| @@ -66,10 +66,13 @@ something like this: | |||
|
|
|||
| At the top of this diagram, we see two applications (also known as "clients"). | |||
| The application on the right is both writing and reading data from the Ceph | |||
| Cluster, by means of the RADOS Gateway (RGW). | |||
| Cluster, by means of the RADOS Gateway (RGW). The application on the left is | |||
| only reading data from the Ceph Cluster, by means of an instance of RADOS | |||
There was a problem hiding this comment.
I might italicize reading to disambiguate the message.
There was a problem hiding this comment.
I'll do that. I appreciate the benefit of your fresh eyes.
Improve the syntax and semantics of the caption of the diagram "Replication of Object Data Between Zones" in doc/radosgw/multisite.rst. Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com> Signed-off-by: Zac Dover <zac.dover@proton.me>
zdover23
force-pushed
the
wip-doc-2023-03-01-radosgw-multisite-diagram-object-replication-text-revision
branch
from
51b8a03
to
e8aa50e
Compare
zdover23
added a commit
to zdover23/ceph
that referenced
this pull request
Mar 5, 2023
Rewrite the third paragraph of the caption to the figure depicting how a zonegroup works. Follows ceph#50316. Signed-off-by: Zac Dover <zac.dover@proton.me>
zdover23
added a commit
to zdover23/ceph
that referenced
this pull request
Mar 6, 2023
Rewrite the third paragraph of the caption to the figure depicting how a zonegroup works. Follows ceph#50316. Signed-off-by: Zac Dover <zac.dover@proton.me> (cherry picked from commit 8fa5214)
zdover23
added a commit
to zdover23/ceph
that referenced
this pull request
Mar 6, 2023
Rewrite the third paragraph of the caption to the figure depicting how a zonegroup works. Follows ceph#50316. Signed-off-by: Zac Dover <zac.dover@proton.me> (cherry picked from commit 8fa5214)
zdover23
added a commit
to zdover23/ceph
that referenced
this pull request
Mar 6, 2023
Rewrite the third paragraph of the caption to the figure depicting how a zonegroup works. Follows ceph#50316. Signed-off-by: Zac Dover <zac.dover@proton.me> (cherry picked from commit 8fa5214)
This was referenced Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the syntax and semantics of the caption of the diagram "Replication of Object Data Between Zones" in doc/radosgw/multisite.rst.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows