Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/cephadm: correct grammar in host-management.rst #50340

Open
wants to merge 1 commit into
base: quincy
Choose a base branch
from

Conversation

tkagn
Copy link

@tkagn tkagn commented Mar 2, 2023

"... will be only affect ..." should read as "... will only affect ..." "...host will no remove any..." should read as "...host will not remove any..."

Signed-off-by: Stephen Wilson swilson@redhat.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

"... will be only affect ..." should read as "... will only affect ..."
"...host will no remove any..." should read as "...host will not remove any..."

Signed-off-by: tkagn <65681641+tkagn@users.noreply.github.com>
@tkagn tkagn requested a review from a team as a code owner March 2, 2023 00:10
@github-actions github-actions bot added this to the quincy milestone Mar 2, 2023
@anthonyeleven
Copy link
Contributor

Hi, thanks for contributing. We have a few conventions that need to be followed before this can be merged.

  • Please edit the PR description and check one box from each of the 4 sections, for a doc change these are pretty clear
  • Please edit the PR title to be an imperative and include the directory modified, like "doc/cephadm: corrections in host-management.rst"
  • Amend the commit title to match
    These are all required by the automated tests before they unblock merging.

-- aad

@zdover23 zdover23 changed the title doc: Edited location attribute note quincy: doc/cephadm: correct grammar in host-management.rst Mar 2, 2023
@zdover23 zdover23 changed the title quincy: doc/cephadm: correct grammar in host-management.rst doc/cephadm: correct grammar in host-management.rst Mar 2, 2023
@zdover23
Copy link
Contributor

zdover23 commented Mar 2, 2023

@tkagn:
See this console output for the exact cause of the "Signed-off by" check's failure:
https://jenkins.ceph.com/job/ceph-pr-commits/17774/console

My best guess is that this can be fixed by running "git commit --amend" and changing the commit message in the git log to the commit message that I have written here. If you run into any difficulty doing this, find me on Slack or write to me at zac.dover@proton.me and I'll help out.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants