Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librbd: report better errors when failing to enable mirroring on an image #50343

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

pkalever
Copy link

@pkalever pkalever commented Mar 2, 2023

Attempting to enable mirroring on an image within a namespace bails out without any useful msg.

$ rbd mirror image enable mi_pool/ns_0/big snapshot
2021-11-17T08:33:21.321+0000 7f4b36f9c2c0 -1 librbd::api::Mirror:image_enable: cannot enable mirroring in the current pool mirroring mode

Fixes: https://tracker.ceph.com/issues/58895

Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@pkalever pkalever requested a review from a team as a code owner March 2, 2023 10:43
@github-actions github-actions bot added the rbd label Mar 2, 2023
src/librbd/api/Mirror.cc Outdated Show resolved Hide resolved
@idryomov
Copy link
Contributor

idryomov commented Mar 2, 2023

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2024444

No need to mention this, the upstream tracker link is enough. BZs are often either completely inaccessible or most of the comments are private.

@pkalever pkalever changed the title rbd: provide hint msg when failing to enable mirroring on image rbd: improve log msgs when failing to enable mirroring on image Mar 6, 2023
@pkalever pkalever requested a review from idryomov March 6, 2023 13:18
src/librbd/api/Mirror.cc Outdated Show resolved Hide resolved
@idryomov idryomov changed the title rbd: improve log msgs when failing to enable mirroring on image librbd: report better errors when failing to enable mirroring on image Mar 6, 2023
@idryomov idryomov changed the title librbd: report better errors when failing to enable mirroring on image librbd: report better errors when failing to enable mirroring on an image Mar 6, 2023
@pkalever pkalever requested a review from idryomov March 6, 2023 14:03
src/librbd/api/Mirror.cc Outdated Show resolved Hide resolved
src/librbd/api/Mirror.cc Outdated Show resolved Hide resolved
Attempting to enable mirroring on an an image within a namespace bails
out without any useful msg.

$ rbd mirror image enable mi_pool/ns_0/big snapshot
2021-11-17T08:33:21.321+0000 7f4b36f9c2c0 -1 librbd::api::Mirror:
  image_enable: cannot enable mirroring in the current pool mirroring mode

Fixes: https://tracker.ceph.com/issues/58895
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
@idryomov
Copy link
Contributor

jenkins test make check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants