Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msg: always generate random nonce; don't try to reuse PID #50344

Merged
merged 3 commits into from May 3, 2023
Merged

msg: always generate random nonce; don't try to reuse PID #50344

merged 3 commits into from May 3, 2023

Conversation

rzarzynski
Copy link
Contributor

We'll need to drop the env. var. from Rook's code base as well.

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@rzarzynski rzarzynski requested review from a team as code owners March 2, 2023 11:57
adk3798
adk3798 approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@adk3798 adk3798 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the story behind why we're doing this, but the cephadm change does look to correctly be removing the env variable as you're intending. So can approve that bit at least.

@github-actions github-actions bot added the mgr label Mar 2, 2023
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@rzarzynski
msg: always generate random nonce; don't try to reuse PID
e27f6c6 
Too much of pain with containerized world. The autodection,
based on `getpid() == 1`, turned out to be problematic.
This patch removes it and switches the behavior to always
use a random-generated nonce.

Fixes: https://tracker.ceph.com/issues/57977
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
@rzarzynski
crimson/osd: always use random number for msgr's nonce
9654095 
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
@rzarzynski
cephadm: don't use CEPH_USE_RANDOM_NONCE anymore
697306d 
It is not necessary anymore as this behavior became
the default one.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
@idryomov
Copy link
Contributor

jenkins test windows

@idryomov
Copy link
Contributor

jenkins test dashboard cephadm

@ljflores
Copy link
Contributor

ljflores commented May 3, 2023

Rados suite review: https://pulpito.ceph.com/?branch=wip-yuri3-testing-2023-04-25-1147

Failures, unrelated:
1. https://tracker.ceph.com/issues/59049
2. https://tracker.ceph.com/issues/59192
3. https://tracker.ceph.com/issues/59335
4. https://tracker.ceph.com/issues/59380
5. https://tracker.ceph.com/issues/58946
6. https://tracker.ceph.com/issues/50371
7. https://tracker.ceph.com/issues/59057
8. https://tracker.ceph.com/issues/53345

Details:
1. WaitReplicas::react(const DigestUpdate&): Unexpected DigestUpdate event - Ceph - RADOS
2. cls/test_cls_sdk.sh: Health check failed: 1 pool(s) do not have an application enabled (POOL_APP_NOT_ENABLED)
3. Found coredumps on smithi related to sqlite3Found coredumps on smithi related to sqlite3 - Ceph - Cephsqlite
4. rados/singleton-nomsgr: test failing from "Health check failed: 1 full osd(s) (OSD_FULL)" and "Health check failed: 1 filesystem is offline (MDS_ALL_DOWN)" - Ceph - RADOS
5. cephadm: KeyError: 'osdspec_affinity' - Ceph - Mgr - Dashboard
6. Segmentation fault (core dumped) ceph_test_rados_api_watch_notify_pp - Ceph - RADOS
7. rados/test_envlibrados_for_rocksdb.sh: No rule to make target 'rocksdb_env_librados_test' on centos 8 - Ceph - RADOS
8. Test failure: test_daemon_restart (tasks.cephadm_cases.test_cli.TestCephadmCLI) - Ceph - Orchestrator

@yuriw yuriw merged commit ef35542 into ceph:main May 3, 2023
10 of 12 checks passed
@adk3798 adk3798 mentioned this pull request Nov 20, 2023
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idryomov idryomov idryomov approved these changes

@adk3798 adk3798 adk3798 approved these changes

@athanatos athanatos Awaiting requested review from athanatos

Assignees
No one assigned
Labels
bug-fix cephadm cleanup core crimson mgr needs-qa wip-yuri3-testing
Projects
None yet
Milestone
No milestone
5 participants
@rzarzynski @idryomov @ljflores @adk3798 @yuriw