New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ceph_volume: support encrypted volumes for lvm new-db/new-wal/migrate commands #50427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifed01
force-pushed
the
wip-ifed-encrypted-ceph-volume
branch
3 times, most recently
from
March 7, 2023 18:18
e258642
to
77b4c86
Compare
ifed01
force-pushed
the
wip-ifed-encrypted-ceph-volume
branch
from
March 9, 2023 13:32
77b4c86
to
4ca126e
Compare
ifed01
changed the title
ceph_volume: support encrypted volumes for lvm new-db/new-wal commands
ceph_volume: support encrypted volumes for lvm new-db/new-wal/migrate commands
Mar 9, 2023
ifed01
force-pushed
the
wip-ifed-encrypted-ceph-volume
branch
2 times, most recently
from
March 9, 2023 15:08
744b52e
to
5510f64
Compare
@guits - ping. |
guits
reviewed
Jun 5, 2023
guits
reviewed
Jun 5, 2023
guits
reviewed
Jun 5, 2023
guits
reviewed
Jun 5, 2023
ifed01
force-pushed
the
wip-ifed-encrypted-ceph-volume
branch
from
June 19, 2023 14:05
5510f64
to
a4bdec2
Compare
14 tasks
Fixes: https://tracker.ceph.com/issues/55167 Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
Fixes: https://tracker.ceph.com/issues/58943 Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
Just a tiny cleanup. Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
ifed01
force-pushed
the
wip-ifed-encrypted-ceph-volume
branch
from
July 25, 2023 15:53
a4bdec2
to
f69316f
Compare
guits
reviewed
Jul 27, 2023
guits
reviewed
Jul 27, 2023
guits
reviewed
Jul 27, 2023
guits
reviewed
Jul 27, 2023
some new comments, can be addressed in a separate PR though (there are existing tests that have already the same @patch() approach) |
guits
approved these changes
Jul 31, 2023
guits
reviewed
Aug 7, 2023
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
jenkins test make check |
This was referenced Aug 8, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/55167
Signed-off-by: Igor Fedotov igor.fedotov@croit.io