Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw/admin: 'bucket stats' displays non-empty mtime #50429

Merged
merged 2 commits into from Mar 11, 2023
Merged

Conversation

cbodley
Copy link
Contributor

@cbodley cbodley commented Mar 7, 2023

fixes two regressions for https://tracker.ceph.com/issues/58932:

  • 90aec61 rgw_get_system_obj() stopped getting mtimes from cache/librados
  • 72d1a36 bucket_stats() left mtime uninitialized
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@cbodley cbodley requested a review from a team as a code owner March 7, 2023 22:57
rgw_get_system_obj() stopped calling stat() before read() in
90aec61, which left the optional
'real_time *pmtime' argument uninitialized

when requested, read() will add a stat op to initialize size/mtime

Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley
Copy link
Contributor Author

cbodley commented Mar 7, 2023

~/ceph/build $ s3cmd mb s3://testbucket                                                                                        
Bucket 's3://testbucket/' created

~/ceph/build $ bin/radosgw-admin bucket stats --bucket testbucket
2023-03-07T18:12:59.353-0500 7fedf5432a00 -1 WARNING: all dangerous and experimental features are enabled.
2023-03-07T18:12:59.360-0500 7fedf5432a00 -1 WARNING: all dangerous and experimental features are enabled.
2023-03-07T18:12:59.361-0500 7fedf5432a00 -1 WARNING: all dangerous and experimental features are enabled.
{
    "bucket": "testbucket",
    "num_shards": 11,
    "tenant": "",
    "zonegroup": "7f6d07c1-c5f5-4dd7-a897-cb52fa74bcff",
    "placement_rule": "default-placement",
    "explicit_placement": {
        "data_pool": "",
        "data_extra_pool": "",
        "index_pool": ""
    },
    "id": "f414a934-f454-40be-b58e-ab70f6e13f27.4147.1",
    "marker": "f414a934-f454-40be-b58e-ab70f6e13f27.4147.1",
    "index_type": "Normal",
    "owner": "testid",
    "ver": "0#1,1#1,2#1,3#1,4#1,5#1,6#1,7#1,8#1,9#1,10#1",
    "master_ver": "0#0,1#0,2#0,3#0,4#0,5#0,6#0,7#0,8#0,9#0,10#0",
    "mtime": "2023-03-07T23:12:50.027215Z",
    "creation_time": "2023-03-07T23:12:47.904675Z",
    "max_marker": "0#,1#,2#,3#,4#,5#,6#,7#,8#,9#,10#",
    "usage": {},
    "bucket_quota": {
        "enabled": false,
        "check_on_raw": false,
        "max_size": -1,
        "max_size_kb": 0,
        "max_objects": -1
    }
}

@cbodley
Copy link
Contributor Author

cbodley commented Mar 11, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants