Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sts: Fixes get_cert_url improper url path concatenation #50462

Merged
merged 1 commit into from Mar 31, 2023
Merged

sts: Fixes get_cert_url improper url path concatenation #50462

merged 1 commit into from Mar 31, 2023

Conversation

matutter
Copy link
Contributor

@matutter matutter commented Mar 9, 2023

Invalid URL concatenation prevents some OpenIDConnect providers from working with RGW and the AssumeRoleWithWebIdentity API. Invalid URLs contain a double slash //. This fix ensures that an ISS is properly joined to the .well-known path.

Fixes: https://tracker.ceph.com/issues/58890

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@matutter
sts: Fixes get_cert_url improper url path concatenation
c71818a 
Invalid URL concatenation prevents some OpenIDConnect providers from working
with RGW and the AssumeRoleWithWebIdentity API. Invalid URLs contain a double
slash `//`. This fix ensures that an ISS is properly joined to the .well-known
path.

Fixes: https://tracker.ceph.com/issues/58890
Signed-off-by: Mathew Utter <mat@hazmat.dev>
@matutter matutter requested a review from a team as a code owner March 9, 2023 16:52
@github-actions github-actions bot added the rgw label Mar 9, 2023
@cbodley
Copy link
Contributor

cbodley commented Mar 31, 2023

passed qa after reruns; see #50648 (comment) for details

@cbodley cbodley merged commit df21f6d into ceph:main Mar 31, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pritha-srivastava pritha-srivastava pritha-srivastava approved these changes

Assignees
No one assigned
Labels
needs-qa rgw wip-cbodley-testing
Projects
None yet
Milestone
No milestone
3 participants
@matutter @cbodley @pritha-srivastava