reef: osd/scrub: only call publish_stats_to_osd() where allowed and needed

[ljflores]

This patch removes several unnecessary calls to publish_stats_to_osd() in the clear_pgscrub_state pathway used during interval changes. We didn't actually have anything to publish and we can't validly call publish_stats_to_osd() when we aren't an active primary anyway (which we can't be during an interval change).

Fixes: https://tracker.ceph.com/issues/58496
Signed-off-by: Ronen Friedman rfriedma@redhat.com
(cherry picked from commit aeff19d)

Backport of #50283

Contribution Guidelines

• To sign and title your commits, please refer to Submitting Patches to Ceph.

• If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

Checklist

• Tracker (select at least one)
  • References tracker ticket
  • Very recent bug; references commit where it was introduced
  • New feature (ticket optional)
  • Doc update (no ticket needed)
  • Code cleanup (no ticket needed)
• Component impact
  • Affects Dashboard, opened tracker ticket
  • Affects Orchestrator, opened tracker ticket
  • No impact that needs to be tracked
• Documentation (select at least one)
  • Updates relevant documentation
  • No doc update is appropriate
• Tests (select at least one)
  • Includes unit test(s)
  • Includes integration test(s)
  • Includes bug reproducer
  • No tests

Show available Jenkins commands

• jenkins retest this please
• jenkins test classic perf
• jenkins test crimson perf
• jenkins test signed
• jenkins test make check
• jenkins test make check arm64
• jenkins test submodules
• jenkins test dashboard
• jenkins test dashboard cephadm
• jenkins test api
• jenkins test docs
• jenkins render docs
• jenkins test ceph-volume all
• jenkins test ceph-volume tox
• jenkins test windows

[ljflores]

Rados suite review: https://pulpito.ceph.com/?branch=wip-yuri4-testing-2023-03-09-1458-reef

Failures, unrelated:
1. https://tracker.ceph.com/issues/57771
2. https://tracker.ceph.com/issues/58560
3. https://tracker.ceph.com/issues/58744
4. https://tracker.ceph.com/issues/59057
5. https://tracker.ceph.com/issues/59049
6. https://tracker.ceph.com/issues/58969
7. https://tracker.ceph.com/issues/57755

Details:
1. orch/cephadm suite: 'TESTDIR=/home/ubuntu/cephtest bash -s' fails - Ceph - Orchestrator
2. rook: failed to pull kubelet image - Ceph - Orchestrator
3. qa: intermittent nfs test failures at nfs cluster creation - Ceph - CephFS
4. rados/test_envlibrados_for_rocksdb.sh: No rule to make target 'rocksdb_env_librados_test' on centos 8 - Ceph - RADOS
5. WaitReplicas::react(const DigestUpdate&): Unexpected DigestUpdate event - Ceph - RADOS
6. test_full_health: _ValError: In input['fs_map']['filesystems'][0]['mdsmap']: missing keys: {'max_xattr_size'} - Ceph - Mgr - Dashboard
7. task/test_orch_cli: test_cephfs_mirror times out - Ceph - Orchestrator
8. SELinux Denials during cephadm/workunits/test_cephadm - Ceph - Orchestrator