Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reef: mgr/telemetry: make sure histograms are formatted in all commands #50481

Merged
merged 1 commit into from Mar 31, 2023

Conversation

ljflores
Copy link
Contributor

@ljflores ljflores commented Mar 10, 2023

I noticed that histograms weren't getting formatted in preview-all and show-all. I made a few tweaks so they are properly formatted now.

I verified this fix on:
ceph telemetry preview
ceph telemetry preview-all
ceph telemetry show
ceph telemetry show-all

Note that only the all commands were affected.

Fixes: https://tracker.ceph.com/issues/58050
Signed-off-by: Laura Flores lflores@redhat.com
(cherry picked from commit 277350e)

Reef backport of #48948
Backport tracker: https://tracker.ceph.com/issues/58980

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

I noticed that histograms weren't getting formatted in `preview-all`
and `show-all`. I made a few tweaks so they are properly formatted now.

I verified this fix on:
`ceph telemetry preview`
`ceph telemetry preview-all`
`ceph telemetry show`
`ceph telemetry show-all`

Note that only the `all` commands were affected.

Fixes: https://tracker.ceph.com/issues/58050
Signed-off-by: Laura Flores <lflores@redhat.com>
(cherry picked from commit 277350e)
@ljflores ljflores requested a review from yaarith March 10, 2023 21:47
@ljflores ljflores added this to the reef milestone Mar 10, 2023
@ljflores
Copy link
Contributor Author

Rados suite review: https://pulpito.ceph.com/?branch=wip-yuri-testing-2023-03-14-0714-reef

Failures, unrelated:
1. https://tracker.ceph.com/issues/59123
2. https://tracker.ceph.com/issues/56393
3. https://tracker.ceph.com/issues/59281
4. https://tracker.ceph.com/issues/59282
5. https://tracker.ceph.com/issues/51964
6. https://tracker.ceph.com/issues/59284
7. https://tracker.ceph.com/issues/56445
8. https://tracker.ceph.com/issues/58130
9. https://tracker.ceph.com/issues/59057
10. https://tracker.ceph.com/issues/59285
11. https://tracker.ceph.com/issues/59286
12. https://tracker.ceph.com/issues/58560

Details:
1. Timeout opening channel - Infrastructure
2. failed to complete snap trimming before timeout - Ceph - RADOS
3. JSONDecodeError: Expecting property name enclosed in double quotes - Ceph - Mgr
4. OSError: [Errno 107] Transport endpoint is not connected - Infrastructure
5. qa: test_cephfs_mirror_restart_sync_on_blocklist failure - Ceph - CephFS
6. Missing /home/ubuntu/cephtest/archive/coredump file or directory - Tools - Teuthology
7. Command failed on smithi162 with status 123: "find /home/ubuntu/cephtest/archive/syslog -name '*.log' -print0 | sudo xargs -0 --no-run-if-empty -- gzip --" - Tools - Teuthology
8. LibRadosAio.SimpleWrite hang and pkill - Ceph - RADOS
9. rados/test_envlibrados_for_rocksdb.sh: No rule to make target 'rocksdb_env_librados_test' on centos 8 - Ceph - RADOS
10. mon/mon-last-epoch-clean.sh: TEST_mon_last_clean_epoch failure due to stuck pgs - Ceph - RADOS
11. mon/test_mon_osdmap_prune.sh: test times out after 5+ hours - Ceph - RADOS
12. rook: failed to pull kubelet image - Ceph - Orchestrator

@yuriw yuriw merged commit 422f77f into ceph:reef Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants