Wip suse 896406 paritions journel overflow #5057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using ceph-disk to create a journal partition in the next available partition and there is not enough space ceph-disk did not provide a clear error message. Signed-off-by: Owen Synge <osynge@suse.com>
This fix is needed as the original commit was for firefly and forward porting needed some changes. Signed-off-by: Owen Synge <osynge@suse.com>
|
@osynge could we discuss this on the mailing list first ? A lot is going on with ceph-disk right now, both features and tests infrastructure :-) |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is reopening of #3093
Ideally I should have a test for this. Im not sure the best way to provide said test suite.
Best wishes
Owen