Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quincy: kv/RocksDBStore: cumulative backport for rm_range_keys and around #50636

Merged
merged 2 commits into from Oct 9, 2023
Merged

quincy: kv/RocksDBStore: cumulative backport for rm_range_keys and around #50636

merged 2 commits into from Oct 9, 2023

Conversation

ifed01
Copy link
Contributor

@ifed01 ifed01 commented Mar 23, 2023 •
edited

backport of #49870
backport of #49748

backport tracker: https://tracker.ceph.com/issues/59140
parent tracker: https://tracker.ceph.com/issues/58463

Signed-off-by: Igor Fedotov igor.fedotov@croit.io

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@ifed01
kv/rocksdbstore: apply rocksdb_delete_range_threshold on the fly
592da6e 
Plus more effective rm_range_keys implementation when this parameter is
set to 0

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit 69704fd)
@ifed01
kv/RocksDBStore: use bounded iterators in rm_range_keys
08252a2 
Fixes: https://tracker.ceph.com/issues/58463
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit b8e669d)
@ifed01 ifed01 requested a review from a team as a code owner March 23, 2023 09:56
@github-actions github-actions bot added the core label Mar 23, 2023
@github-actions github-actions bot added this to the quincy milestone Mar 23, 2023
@ifed01 ifed01 requested review from aclamk and cfsnyder March 23, 2023 09:59
@ifed01 ifed01 added the needs-qa label Oct 5, 2023
@ljflores
Copy link
Contributor

ljflores commented Oct 9, 2023

Rados approved: https://tracker.ceph.com/projects/rados/wiki/QUINCY#httpstrellocomcL3dTGoH11854-wip-yuri8-testing-2023-10-05-1127-quincy

@yuriw yuriw merged commit c0cafa4 into ceph:quincy Oct 9, 2023
10 of 12 checks passed
@ifed01 ifed01 deleted the wip-ifed-bound-rm-range-keys-qui branch October 15, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclamk aclamk aclamk approved these changes

@cfsnyder cfsnyder Awaiting requested review from cfsnyder

Assignees
No one assigned
Labels
backport quincy core needs-qa performance wip-yuri8-testing
Projects
None yet
Milestone
quincy
4 participants
@ifed01 @ljflores @aclamk @yuriw