Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quincy: rbd-mirror: switch to labeled perf counters #50689

Closed
wants to merge 1 commit into from

Conversation

weirdwiz
Copy link
Contributor

backport tracker: https://tracker.ceph.com/issues/59176


backport of #50302
parent tracker: https://tracker.ceph.com/issues/59173

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh

…roring

This commit renames the existing snapshot and journal based performance
counters in the rbd-mirror daemon to better reflect their purpose.
Additionally, new perf counters have been added to provide more detailed
information about the synchronization of snapshots between the source
and destination clusters.

This commit also switches to use labels instead of having the image spec
in the name of the counter.

Signed-off-by: Divyansh Kamboj <dkamboj@redhat.com>
(cherry picked from commit 1a1477b)
@weirdwiz weirdwiz requested a review from a team as a code owner March 27, 2023 14:45
@github-actions github-actions bot added the rbd label Mar 27, 2023
@github-actions github-actions bot added this to the quincy milestone Mar 27, 2023
Copy link
Contributor

@idryomov idryomov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to need #48657 backported first (otherwise it won't even build).

@idryomov
Copy link
Contributor

#48657 is not getting backported to quincy.

@idryomov idryomov closed this Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants