Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw/admin: 'data sync status' formats binary error repo entries #50690

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

cbodley
Copy link
Contributor

@cbodley cbodley commented Mar 27, 2023

the error repo keys were converted to a binary format for resharding support, so they could encode the optional generation number. the data sync status command now uses rgw::error_repo::decode_key() to parse these and format them correctly

Fixes: https://tracker.ceph.com/issues/59174

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@cbodley cbodley requested a review from a team as a code owner March 27, 2023 14:58
@cbodley
Copy link
Contributor Author

cbodley commented Mar 27, 2023

without the fix:

    "recovering_buckets": [
        "<80>\u0001\u0001Z\u0000\u0000\u0000\n\nG\u0000\u0000\u0000\u0006\u0000\u0000\u0000testbucket\u0000\u0000\u0000\u00000\u0000\u0000\u0000f48cfc12-b34a-4ba8-a849-10785cc33c8a.4190.1\u0000\u0000\u0000\u0000\u0000<FF><FF><FF><FF>\u0002\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000" 
    ]

and with:

    "recovering_buckets": [                                                                                                                                   
        "testbucket:f48cfc12-b34a-4ba8-a849-10785cc33c8a.4190.1:2[0]"                                                                                         
    ],

@mattbenjamin
Copy link
Contributor

this is showing up in output from downstream users on rhcs-5.3, obviously; I would like to create bzs for downstream backports, would that be problematic?

@cbodley
Copy link
Contributor Author

cbodley commented Mar 27, 2023

this is showing up in output from downstream users on rhcs-5.3, obviously; I would like to create bzs for downstream backports, would that be problematic?

please do!

Copy link
Contributor

@mattbenjamin mattbenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cbodley
Copy link
Contributor Author

cbodley commented Mar 31, 2023

passed qa after reruns; see #50648 (comment) for details

@cbodley cbodley merged commit 01096e8 into ceph:main Mar 31, 2023
@cbodley cbodley deleted the wip-59174 branch March 31, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants