Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/cephfs: include lost+found in scan_links #50692

Merged
merged 1 commit into from Mar 30, 2023
Merged

Conversation

batrick
Copy link
Member

@batrick batrick commented Mar 27, 2023

Otherwise, any injected dentries have incorrect first snapids.

Fixes: https://tracker.ceph.com/issues/59183

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

Otherwise, any injected dentries have incorrect first snapids.

Fixes: https://tracker.ceph.com/issues/59183
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
@batrick
Copy link
Member Author

batrick commented Mar 28, 2023

2023-03-27T23:19:01.924 INFO:teuthology.orchestra.run.smithi018.stderr:2023-03-27T23:19:01.904+0000 7f37292527c0 10 datascan.scan_links: step 2: handling object 4.00000000
2023-03-27T23:19:01.924 INFO:teuthology.orchestra.run.smithi018.stderr:2023-03-27T23:19:01.904+0000 7f37292527c0  1 -- 172.21.15.18:0/699875016 --> [v2:172.21.15.136:6817/110352,v1:172.21.15.136:6819/110352] -- osd_op(unknown.0.0:68 30.3 30:c0ce80d4:::4.00000000:head [omap-get-vals in=16b] snapc 0=[] ondisk+read+known_if_redirected+supports_pool_eio e234) v8 -- 0x56054d224800 con 0x56054d112800
2023-03-27T23:19:01.924 INFO:teuthology.orchestra.run.smithi018.stderr:2023-03-27T23:19:01.905+0000 7f371a3fc700  1 -- 172.21.15.18:0/699875016 <== osd.6 v2:172.21.15.136:6817/110352 14 ==== osd_op_reply(68 4.00000000 [omap-get-vals out=513b] v0'0 uv2 ondisk = 0) v8 ==== 154+0+513 (crc 0 0 0) 0x56054d0f38c0 con 0x56054d112800
2023-03-27T23:19:01.924 INFO:teuthology.orchestra.run.smithi018.stderr:2023-03-27T23:19:01.905+0000 7f37292527c0 20 datascan.scan_links: injected ino detected
2023-03-27T23:19:01.925 INFO:teuthology.orchestra.run.smithi018.stderr:2023-03-27T23:19:01.905+0000 7f37292527c0 20 datascan.scan_links: adding 0x10000000001 for future processing to fix dnfirst

/teuthology/pdonnell-2023-03-27_22:29:12-fs-wip-pdonnell-testing-20230327.200655-distro-default-smithi/7221874/teuthology.log

Fixed now.

batrick added a commit to batrick/ceph that referenced this pull request Mar 28, 2023
* refs/pull/50692/head:
	tools/cephfs: include lost+found in scan_links
batrick added a commit to batrick/ceph that referenced this pull request Mar 28, 2023
* refs/pull/50692/head:
	tools/cephfs: include lost+found in scan_links
@batrick
Copy link
Member Author

batrick commented Mar 28, 2023

jenkins test make check arm64

1 similar comment
@batrick
Copy link
Member Author

batrick commented Mar 28, 2023

jenkins test make check arm64

@batrick
Copy link
Member Author

batrick commented Mar 29, 2023

@vshankar vshankar requested a review from a team March 29, 2023 13:00
@vshankar
Copy link
Contributor

I wonder if the first field corruption is a fallout from this issue? Seems alarmingly close to what we've been seeing.

@batrick
Copy link
Member Author

batrick commented Mar 29, 2023

I wonder if the first field corruption is a fallout from this issue? Seems alarmingly close to what we've been seeing.

We had thought so but it requires running cephfs-data-scan which none of the clusters had used (to our knowledge).

@batrick batrick merged commit 3c43488 into ceph:main Mar 30, 2023
10 of 11 checks passed
@batrick batrick deleted the i59183 branch March 30, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants