Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qa: switch to use merge fragment to filter the kclient #50729

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

qa: switch to use merge fragment to filter the kclient #50729

wants to merge 1 commit into from

Conversation

lxbsz
Copy link
Member

@lxbsz lxbsz commented Mar 29, 2023

PR #48183 have add the merge fragment support. This will switch to use fragment to simplify the code.

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@lxbsz lxbsz added cephfs Ceph File System needs-qa labels Mar 29, 2023
@lxbsz lxbsz requested a review from a team March 29, 2023 05:57
@lxbsz
Copy link
Member Author

lxbsz commented Mar 29, 2023

All the relevant qa tests are running.

@lxbsz lxbsz force-pushed the wip-merge-fragment branch 2 times, most recently from 9598d4f to 2f553bc Compare March 29, 2023 07:09
@lxbsz
Copy link
Member Author

lxbsz commented Mar 29, 2023

Only updated the commit comments.

dparmar18
dparmar18 approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@dparmar18 dparmar18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dparmar18
Copy link
Contributor

All the relevant qa tests are running.

all dead due to '7548196cdacea28b374443a9304dc4f8702e673e' not found in repo: https://github.com/lxbsz/ceph.git!

@lxbsz
Copy link
Member Author

lxbsz commented Mar 29, 2023

All the relevant qa tests are running.

all dead due to '7548196cdacea28b374443a9304dc4f8702e673e' not found in repo: https://github.com/lxbsz/ceph.git!

I have force pushed this branch and caused this issue. I have fire the qa tests.

@dparmar18 dparmar18 self-requested a review March 29, 2023 11:59
@lxbsz lxbsz marked this pull request as draft March 29, 2023 12:19
@batrick
Copy link
Member

batrick commented Mar 30, 2023

@lxbsz also have a look at #46882

I hope to revive that PR in the near future.

@lxbsz
Copy link
Member Author

lxbsz commented Mar 31, 2023

@lxbsz also have a look at #46882

I hope to revive that PR in the near future.

@batrick Yeah, sure I will review your PR today and will revive this one once after I successfully run the tests later.

Thanks,

@rishabh-d-dave
Copy link
Contributor

@lxbsz Should this be put through QA?

@lxbsz
Copy link
Member Author

lxbsz commented Apr 3, 2023

@lxbsz Should this be put through QA?

@rishabh-d-dave This is not ready yet. Thanks.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Sep 22, 2023
@github-actions
Copy link

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@github-actions github-actions bot closed this Oct 22, 2023
@dparmar18
Copy link
Contributor

Hi @lxbsz, this might've failed in QA run since you've added the .qa/cephfs/mount/ symlink directly inside qa/suites/fs/upgrade/mds_upgrade_sequence but it needs to be inside qa/suites/fs/upgrade/mds_upgrade_sequence/tasks since the scope of function is_fuse() is limited to local dir and therefore qa/suites/fs/upgrade/mds_upgrade_sequence/tasks/2-client.yaml won't be able to find it.

Looking at the dir structure; you'd also need to make name changes inside tasks/ as well, it would be now 0-from, 1-mount.yaml, 2-volume and so on. Also reading this comment from 898316a makes me think if that is needed here too. Does the distro kernels now have the newops fixes?

@dparmar18 dparmar18 reopened this Oct 23, 2023
@github-actions github-actions bot removed the stale label Oct 23, 2023
@lxbsz
qa: switch to use merge fragment to filter the kclient
c5afa6a 
The mds_upgrade_sequence tests aim to test the ceph cluster upgrading,
and it doesn't matter about the clients. And keep using the kclient to
run the tests as it was.

Fixes: https://tracker.ceph.com/issues/59197
Signed-off-by: Xiubo Li <xiubli@redhat.com>
@lxbsz
Copy link
Member Author

lxbsz commented Oct 26, 2023

Hi @lxbsz, this might've failed in QA run since you've added the .qa/cephfs/mount/ symlink directly inside qa/suites/fs/upgrade/mds_upgrade_sequence but it needs to be inside qa/suites/fs/upgrade/mds_upgrade_sequence/tasks since the scope of function is_fuse() is limited to local dir and therefore qa/suites/fs/upgrade/mds_upgrade_sequence/tasks/2-client.yaml won't be able to find it.

Looking at the dir structure; you'd also need to make name changes inside tasks/ as well, it would be now 0-from, 1-mount.yaml, 2-volume and so on. Also reading this comment from 898316a makes me think if that is needed here too. Does the distro kernels now have the newops fixes?

Sounds correct. I have fixed it. @dparmar18 Please take a look. Thanks.

@lxbsz lxbsz marked this pull request as ready for review October 26, 2023 06:47
@dparmar18
Copy link
Contributor

jenkins test make check

@github-actions github-actions bot added the stale label Jan 23, 2024
@github-actions github-actions bot removed the stale label Feb 2, 2024
@github-actions github-actions bot added the stale label Apr 2, 2024
@github-actions github-actions bot closed this May 2, 2024
@batrick batrick reopened this May 2, 2024
@ceph ceph deleted a comment from github-actions bot May 2, 2024
@ceph ceph deleted a comment from github-actions bot May 2, 2024
@ceph ceph deleted a comment from github-actions bot May 2, 2024
@batrick batrick removed the stale label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@batrick batrick batrick approved these changes

@dparmar18 dparmar18 dparmar18 approved these changes

Assignees
No one assigned
Labels
cephfs Ceph File System
Projects
None yet
Milestone
No milestone
4 participants
@lxbsz @dparmar18 @batrick @rishabh-d-dave