Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quincy: cephfs-top: navigate to home screen when no fs #50731

Merged
merged 3 commits into from Jun 8, 2023
Merged

quincy: cephfs-top: navigate to home screen when no fs #50731

merged 3 commits into from Jun 8, 2023

Conversation

joscollin
Copy link
Member

@joscollin joscollin commented Mar 29, 2023 •
edited

Fixes: https://tracker.ceph.com/issues/58983

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@github-actions github-actions bot added the cephfs Ceph File System label Mar 29, 2023
@github-actions github-actions bot added this to the quincy milestone Mar 29, 2023
@joscollin
cephfs-top: display filters in the header
2158a00 
This would help the user to identify what are the filters currently applied
to the cephfs-top screens at a glance.

Signed-off-by: Jos Collin <jcollin@redhat.com>
(cherry picked from commit 7792422)
@joscollin
cephfs-top: replace isinstance call with active_screen variable
59dc33e 
Signed-off-by: Jos Collin <jcollin@redhat.com>
(cherry picked from commit 7453fee)
@joscollin
cephfs-top: navigate to home screen when no fs
b2db8f9 
Return back to the home (All Filesystem Info) screen,
when all the filesystems are removed while waiting for a key input in set_key().
There's no need to return to `Selected FS` screen.

Fixes: https://tracker.ceph.com/issues/58823
Signed-off-by: Jos Collin <jcollin@redhat.com>
(cherry picked from commit 61e097b)
@joscollin
Copy link
Member Author

FYI: The commits 2158a00 and 59dc33e were added to this PR just to automatically resolve the conflicts while cherry-picking the actual fix b2db8f9.

@joscollin
Copy link
Member Author

jenkins test make check

@joscollin joscollin mentioned this pull request May 24, 2023
Merged
mchangir
mchangir approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@mchangir mchangir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuriw yuriw merged commit 376cf03 into ceph:quincy Jun 8, 2023
10 checks passed
@joscollin joscollin deleted the wip-58983-quincy branch June 8, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchangir mchangir mchangir approved these changes

Assignees
No one assigned
Labels
bug-fix cephfs Ceph File System needs-qa wip-yuri6-testing
Projects
None yet
Milestone
quincy
4 participants
@joscollin @mchangir @vshankar @yuriw