Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: set init_check_compat when bucket sync status doesn't exist #50746

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

cbodley
Copy link
Contributor

@cbodley cbodley commented Mar 29, 2023

existing buckets aren't able to resume incremental sync after upgrade to multisite reshard, because the compatibility check wasn't being enabled

Fixes: https://tracker.ceph.com/issues/59211

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley cbodley requested a review from smanjara March 29, 2023 15:05
@cbodley cbodley requested a review from a team as a code owner March 29, 2023 15:05
@cbodley
Copy link
Contributor Author

cbodley commented Mar 29, 2023

output from bucket sync run after deleting the bucket.full-sync-status object with rados rm:

2023-03-29T11:04:59.519-0400 7f9b56841f80 20 data sync: writing bucket sync status during init. state=incremental. marker=

output from bucket sync run after bucket sync init:

2023-03-29T11:13:45.132-0400 7f6fa523cf80 20 data sync: writing bucket sync status during init. state=full. marker=

Copy link
Contributor

@mkogan1 mkogan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with downstream equivalents of PRI Pacific <--> SEC Nautilus, bi-directional 1 M obj sync repro

before this fix, the objects from Nautilus would not transfer to Pacific while objects from Pacific would transfer to Nautilus
[left Pacific, right Nautilus]
image

after this fix PR the sync between Pacific and Nautilus works both ways
[left pacific, right Nautilus]
image

@mattbenjamin
Copy link
Contributor

woot!

@cbodley
Copy link
Contributor Author

cbodley commented Mar 30, 2023

before this fix, the objects from Pacific would not sync to Nautilus while objects from Nautilus would sync to Pacific

thanks for testing, @mkogan1. it would be great if this resolves both upgrade issues, but i worry that we might be missing something here. this fix should only apply to Pacific syncing objects from Nautilus, not the other way around

@mkogan1
Copy link
Contributor

mkogan1 commented Mar 30, 2023

before this fix, the objects from Pacific would not sync to Nautilus while objects from Nautilus would sync to Pacific

thanks for testing, @mkogan1. it would be great if this resolves both upgrade issues, but i worry that we might be missing something here. this fix should only apply to Pacific syncing objects from Nautilus, not the other way around

@cbodley apologizing for the confusion, the fix indeed applies to Pacific syncing objects from Nautilus edited the original message with the correct wording

@mattbenjamin
Copy link
Contributor

but is there then an issue in the reverse direction that customers are experiencing?

@cbodley
Copy link
Contributor Author

cbodley commented Mar 30, 2023

@cbodley apologizing for the confusion, the fix indeed applies to Pacific syncing objects from Nautilus edited the original message with the correct wording

okay, thanks

@cbodley
Copy link
Contributor Author

cbodley commented Mar 31, 2023

jenkins test make check

@cbodley
Copy link
Contributor Author

cbodley commented Mar 31, 2023

passed qa after reruns; see #50648 (comment) for details

@cbodley cbodley merged commit 6a46f9f into ceph:main Mar 31, 2023
@cbodley cbodley deleted the wip-rgw-bucket-full-sync-compat branch March 31, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants