quincy: exporter: user only counter dump/schema commands for extacting counters #50749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: https://tracker.ceph.com/issues/59191 Signed-off-by: Avan Thakkar <athakkar@redhat.com> Ceph exporter no more required the output of perf dump/schema, as the ``counter dump`` command returns both labeled and unlabeled perf counters which exporter can fetch and export. Removed the ``exporter_get_labeled_counters`` confiug option as exporter will now export all the counters, labeled or unlabeled. Also the fix includes the support for renaming the metrics name of rgw multi-site and adding labels to it, similar to what is there in prometheus module. (cherry picked from commit 51a8990)
|
jenkins test api |
|
jenkins test make check |
jmolmo
approved these changes
Mar 31, 2023
idryomov
reviewed
Oct 24, 2023
There was a problem hiding this comment.
@avanthakkar counter dump and counter schema commands aren't available in quincy, which means that exporter won't function with this PR. How was this tested?
It looks like this had (and still has) a Do-Not-Merge label. I'm pretty sure we need an urgent revert here because 17.2.7 is about to ship.
Happening in #54169 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/59214
backport of #50718
parent tracker: https://tracker.ceph.com/issues/59191
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh