Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include: move ALLPERMS definition to compat.h #50793

Merged
merged 1 commit into from Mar 31, 2023

Conversation

petrutlucian94
Copy link
Contributor

@petrutlucian94 petrutlucian94 commented Mar 30, 2023

The Windows CI job started to fail as some libcephfs tests that use
ALLPERMS have been moved [1] to a separate file which doesn't have
the ALLPERMS definition.

/ceph/src/test/libcephfs/suidsgid.cc:240:36: error: ‘ALLPERMS’ was not declared in this scope
240 |   ASSERT_EQ(stx.stx_mode & (mode_t)ALLPERMS, before_mode);

We'll move this definition to compat.h so that we won't have to
redefine it in each file that uses it.

Note that we're moving the Windows "fs_compat.h" include up,
ensuring that the constants used by ALLPERMS are defined.

[1] 254eeb2

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@petrutlucian94 petrutlucian94 added the win32 Specifix changes for the windows platform label Mar 30, 2023
@petrutlucian94 petrutlucian94 changed the title include: define ALLPERMS in src/include/win32/fs_compat.h include: add missing ALLPERMS definition on Windows Mar 30, 2023
The Windows CI job started to fail as some libcephfs tests that use
ALLPERMS have been moved [1] to a separate file which doesn't have
the ALLPERMS definition.

  /ceph/src/test/libcephfs/suidsgid.cc:240:36: error: ‘ALLPERMS’ was
  not declared in this scope
  240 |   ASSERT_EQ(stx.stx_mode & (mode_t)ALLPERMS, before_mode);

We'll move this definition to compat.h so that we won't have to
redefine it in each file that uses it.

Note that we're moving the Windows "fs_compat.h" include up,
ensuring that the constants used by ALLPERMS are defined.

[1] ceph@254eeb2

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
@github-actions github-actions bot added cephfs Ceph File System tests labels Mar 31, 2023
@idryomov idryomov changed the title include: add missing ALLPERMS definition on Windows include: move ALLPERMS definition to compat.h Mar 31, 2023
@idryomov idryomov merged commit e1c5ea5 into ceph:main Mar 31, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cephfs Ceph File System tests win32 Specifix changes for the windows platform
Projects
None yet
2 participants