mon/MDSMonitor: batch last_metadata update with pending #50862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
I believe the problem here is that the last_metadata change is lost in a ECANCELED/EAGAIN transaction but the pending map change goes through in the next one. I've been unable to find an exact way to reproduce this. The problem seems to occur when upgrades are performed which would indicate shuffling in the monitors where quorum would be lost repeatedly. This seems to be the most likely explanation so let's go ahead and make this change even without the reproducer. In any case, it has the added benefit of batching the pending map update (to up:standby) with the last_metadata update. Fixes: https://tracker.ceph.com/issues/24403 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
vshankar
reviewed
Apr 5, 2023
|
Haven't gone over the weeds of |
batrick
added a commit
to batrick/ceph
that referenced
this pull request
May 9, 2023
* refs/pull/50862/head: mon/MDSMonitor: batch last_metadata update with pending mon/MDSMonitor: add debugging for update_metadata
batrick
added a commit
to batrick/ceph
that referenced
this pull request
May 18, 2023
* refs/pull/50862/head: mon/MDSMonitor: batch last_metadata update with pending mon/MDSMonitor: add debugging for update_metadata
batrick
added a commit
to batrick/ceph
that referenced
this pull request
May 20, 2023
* refs/pull/50862/head: mon/MDSMonitor: batch last_metadata update with pending mon/MDSMonitor: add debugging for update_metadata
|
jenkins test make check arm64 |
|
@mchangir can you review this please? |
vshankar
approved these changes
Jun 15, 2023
This was referenced Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows