Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: delete-ceph-authx #50918

Merged
merged 1 commit into from Apr 19, 2023
Merged

mgr/dashboard: delete-ceph-authx #50918

merged 1 commit into from Apr 19, 2023

Conversation

Pegonzal
Copy link
Contributor

@Pegonzal Pegonzal commented Apr 6, 2023 •
edited

Add option to delete users on ceph authx

image

Fixes: https://tracker.ceph.com/issues/59365
Signed-off-by: Pedro Gonzalez Gomez pegonzal@redhat.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@Pegonzal Pegonzal requested a review from a team as a code owner April 6, 2023 14:23
@Pegonzal Pegonzal requested review from avanthakkar and nizamial09 and removed request for a team April 6, 2023 14:23
nizamial09
nizamial09 reviewed Apr 12, 2023
View reviewed changes
Copy link
Member

@nizamial09 nizamial09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @Pegonzal

Although the delete shouldn't happen that quickly. When you click delete it should open up a simple modal and ask the user to confirm the deletion. Otherwise its a surprise for him. Because I was expecting a modal but got suprised that it got deleted immediately. But relieved that it actually got deleted xD.

src/pybind/mgr/dashboard/controllers/_crud.py Show resolved Hide resolved
@Pegonzal
Copy link
Contributor Author

Looks good to me @Pegonzal

Although the delete shouldn't happen that quickly. When you click delete it should open up a simple modal and ask the user to confirm the deletion. Otherwise its a surprise for him. Because I was expecting a modal but got suprised that it got deleted immediately. But relieved that it actually got deleted xD.

Wops, you are right. I added the modal to ask for confirmation before the deletion, thanks for the review @nizamial09

nizamial09
nizamial09 approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@nizamial09 nizamial09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @Pegonzal, some minor nits.

src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/crud-table/crud-table.component.ts Outdated Show resolved Hide resolved
src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/crud-table/crud-table.component.ts Outdated Show resolved Hide resolved
@Pegonzal
mgr/dashboard: delete-ceph-authx
6b5a00f 
Fixes: https://tracker.ceph.com/issues/59365
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
pereman2
pereman2 approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@pereman2 pereman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nizamial09 nizamial09 merged commit eeba8e5 into ceph:main Apr 19, 2023
8 of 13 checks passed
@nizamial09 nizamial09 deleted the delete-ceph-authx branch April 19, 2023 07:40
yuvalif pushed a commit to yuvalif/ceph that referenced this pull request Apr 30, 2023
@nizamial09 @yuvalif
Merge pull request ceph#50918 from rhcs-dashboard/delete-ceph-authx
c622c2c 
mgr/dashboard: delete-ceph-authx

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
@Pegonzal Pegonzal mentioned this pull request May 5, 2023
Merged
@pereman2 pereman2 mentioned this pull request May 5, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pereman2 pereman2 pereman2 approved these changes

@nizamial09 nizamial09 nizamial09 approved these changes

@avanthakkar avanthakkar Awaiting requested review from avanthakkar avanthakkar is a code owner automatically assigned from ceph/dashboard

Assignees
No one assigned
Labels
api-change dashboard pybind
Projects
None yet
Milestone
No milestone
3 participants
@Pegonzal @pereman2 @nizamial09