Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reef: kv/RocksDBStore: don't use real wholespace iterator for prefixed access #50937

Merged
merged 2 commits into from Jun 7, 2023
Merged

reef: kv/RocksDBStore: don't use real wholespace iterator for prefixed access #50937

merged 2 commits into from Jun 7, 2023

Conversation

ifed01
Copy link
Contributor

@ifed01 ifed01 commented Apr 7, 2023 •
edited

backport of #49963

backport tracker: https://tracker.ceph.com/issues/58976
parent tracker: https://tracker.ceph.com/issues/58964

Signed-off-by: Igor Fedotov igor.fedotov@croit.io

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@ifed01
kv/RocksDBStore: avoid redundant prefix lookup.
1b39f71 
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit deb2f97)
@ifed01
kv/RocksDBStore: don't use real wholespace iterator for prefixed access
65eff75 
We can bound to default CF when here are no matching CF for a specified prefix.
No need to use real wholespace iterator running over every CF. Hence we
might benefit from not iterating over large but useless CFs, e.g. OMAP related ones.

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit 46c0a61)
@ifed01 ifed01 requested review from cfsnyder and aclamk April 7, 2023 11:11
@ifed01 ifed01 requested a review from a team as a code owner April 7, 2023 11:11
@github-actions github-actions bot added the core label Apr 7, 2023
@ifed01
Copy link
Contributor Author

ifed01 commented Apr 10, 2023

jenkins test windows

@ifed01
Copy link
Contributor Author

ifed01 commented Apr 10, 2023

jenkins test make check

@ifed01
Copy link
Contributor Author

ifed01 commented Apr 10, 2023

jenkins test api

@ljflores ljflores added this to the reef milestone May 30, 2023
@ljflores
Copy link
Contributor

ljflores commented Jun 1, 2023

Rados suite review: https://tracker.ceph.com/projects/rados/wiki/REEF#httpstrellocomcpeDC5BgN1772-wip-yuri3-testing-2023-05-31-0931-reef

@yuriw yuriw merged commit b9f514b into ceph:reef Jun 7, 2023
10 of 13 checks passed
@ifed01 ifed01 deleted the wip-ifed-fix-prefixed-kv-iterator-reef branch June 13, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclamk aclamk aclamk approved these changes

@cfsnyder cfsnyder Awaiting requested review from cfsnyder

Assignees
No one assigned
Labels
backport reef backport bluestore core needs-qa performance wip-yuri3-testing
Projects
None yet
Milestone
reef
4 participants
@ifed01 @ljflores @aclamk @yuriw