Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph-volume: make disk.is_device follow symlinks #50938

Closed
wants to merge 1 commit into from

Commits on Apr 7, 2023

  1. ceph-volume: make disk.is_device follow symlinks

    When calling ceph-volume on a symlink, the user intends to use the
    device which is the target of the symlink. Change disk.is_device() to
    use os.stat instead of os.lstat. This ensures we check whether the
    target of the symlink is a block device.
    
    This fixes adding multipath devices which can be accessed via
    /dev/mapper/<id> but are symlinks to ../dm-<num>.
    
    Fixes: https://tracker.ceph.com/issues/59375
    Signed-off-by: Pierre Riteau <pierre@stackhpc.com>
    priteau committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    ac6bd60 View commit details
    Browse the repository at this point in the history