pacific: mgr/volumes: avoid returning -ESHUTDOWN back to cli #51039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think mgr/volumes is acting a bit fancy by checking if the ceph-mgr daemon and plugins are under termination, thereby returning -ESHUTDOWN to cli commands. This seems unnecessary. None of the other mgr plugins do anything like this. Handling of commands when the ceph-mgr is under termination is possibly handled in one of the upper layers. Fixes: http://tracker.ceph.com/issues/58651 Signed-off-by: Venky Shankar <vshankar@redhat.com> (cherry picked from commit 32ffcfd) Conflicts: src/pybind/mgr/volumes/fs/volume.py rename_fs_volume() is not present in pacific.
|
jenkins retest this please |
|
jenkins test api |
|
jenkins test make check |
yuriw
added
wip-yuri2-testing
wip-yuri8-testing
and removed
wip-yuri11-testing
wip-yuri8-testing
labels
|
jenkins test make check |
batrick
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tracker.ceph.com/issues/59003
I think mgr/volumes is acting a bit fancy by checking if the ceph-mgr daemon and plugins are under termination, thereby returning -ESHUTDOWN to cli commands. This seems unnecessary. None of the other mgr plugins do anything like this.
Handling of commands when the ceph-mgr is under termination is possibly handled in one of the upper layers.
Fixes: http://tracker.ceph.com/issues/58651
Signed-off-by: Venky Shankar vshankar@redhat.com
(cherry picked from commit 32ffcfd)
Conflicts:
src/pybind/mgr/volumes/fs/volume.py
rename_fs_volume() is not present in pacific.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows