Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quincy: mgr: Add one finisher thread per module #51044

Merged
merged 4 commits into from May 24, 2023

Conversation

kotreshhr
Copy link
Contributor

@kotreshhr kotreshhr commented Apr 12, 2023

backport tracker: https://tracker.ceph.com/issues/59416


Added following dependent qa commits from main branch:

  1. 8114bdd
  2. d8ec1bd

backport of #47893
parent tracker: https://tracker.ceph.com/issues/51177

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh

kotreshhr and others added 4 commits April 12, 2023 15:20
Adds a finisher thread for each module. Each module command is
executed via corresponding finisher thread. There is generic
finisher thread via which all other commands like notify, config
is run.

Fixes: https://tracker.ceph.com/issues/51177
Signed-off-by: Kotresh HR <khiremat@redhat.com>
(cherry picked from commit 46de643)
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 8114bdd)
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit d8ec1bd)
Fixes: https://tracker.ceph.com/issues/51177
Signed-off-by: Kotresh HR <khiremat@redhat.com>
(cherry picked from commit 2c2ef6d)
@kotreshhr kotreshhr requested a review from a team as a code owner April 12, 2023 10:03
@kotreshhr kotreshhr added this to the quincy milestone Apr 12, 2023
@kotreshhr kotreshhr added the core label Apr 12, 2023
@github-actions github-actions bot added cephfs Ceph File System mgr tests labels Apr 12, 2023
@kotreshhr kotreshhr requested a review from a team April 12, 2023 10:04
@kotreshhr
Copy link
Contributor Author

jenkins test make check

@kotreshhr
Copy link
Contributor Author

jenkins test api

@ajarr
Copy link
Contributor

ajarr commented May 16, 2023

@vshankar I think you may want to add quincy-batch-1 as well so that @yuriw can pick this up for quincy testing?

@vshankar
Copy link
Contributor

@vshankar I think you may want to add quincy-batch-1 as well so that @yuriw can pick this up for quincy testing?

I used to do that, but Yuri picked up PRs that have needs-qa tag, so, I stopped using that (additional) label.

@ljflores
Copy link
Contributor

@kotreshhr
Copy link
Contributor Author

Reviewed-by: Kotresh HR khiremat@redhat.com

Copy link
Contributor

@yuriw yuriw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Kotresh HR khiremat@redhat.com

@yuriw yuriw merged commit 5918946 into ceph:quincy May 24, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants