pacific: cephadm: mount host /etc/hosts for daemon containers in podman deployments #51174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Podman messes with the /etc/hosts file in certain version. There was already a past issue with it placing the container name there fixed by ceph#42242. This time it is adding an entry for "host.containers.internal" (seems to be podman 4.1 onward currently). Iscsi figures out the FQDN for a host by running python3 -c 'import socket; print(socket.getfqdn()) which is resolving to "host.containers.internal" when run in the container with the podman modified /etc/hosts. There is also an issue with grafana dashboard with this entry present Passing --no-hosts resolves this, but I think in the past we avoided that due to not wanting to break deployments where host name resolution was handled using /etc/hosts. That's why we had that workaround previously linked. This time I'm not sure such a workaround exists. The try here is to mount a copy of the host's version of /etc/hosts into the iscsi container. That copy won't have the extra entry podman adds in but will have any user created entries in case they were actually using it for host name resolution. If /etc/hosts file isn't present for whatever reason, we're assuming that this user isn't using /etc/hosts for hostname resolution, and just going back to passing --no-hosts. Fixes: https://tracker.ceph.com/issues/58532 Fixes: https://tracker.ceph.com/issues/57018 Signed-off-by: Adam King <adking@redhat.com> (cherry picked from commit dd8627b)
…hosts To make sure we aren't being affected by any podman introduced changes to the /etc/hosts file and test that we're properly mounting /etc/hosts in our daemon containers Signed-off-by: Adam King <adking@redhat.com> (cherry picked from commit 5493e2d) Conflicts: qa/suites/orch/cephadm/dashboard/0-distro/centos_8.stream_container_tools.yaml qa/suites/orch/cephadm/thrash-old-clients/0-size-min-size-overrides/.qa qa/suites/orch/cephadm/workunits/task/test_iscsi_container/.qa qa/suites/orch/cephadm/workunits/task/test_iscsi_container/centos_8.stream_container_tools.yaml qa/suites/orch/cephadm/workunits/task/test_iscsi_container/test_iscsi_container.yaml qa/suites/orch/cephadm/workunits/task/test_iscsi_pids_limit.yaml qa/suites/orch/cephadm/workunits/task/test_iscsi_pids_limit/.qa qa/suites/orch/cephadm/workunits/task/test_iscsi_pids_limit/centos_8.stream_container_tools.yaml qa/suites/orch/cephadm/workunits/task/test_iscsi_pids_limit/test_iscsi_pids_limit.yaml (due to test_iscsi_pids_limit not backported)
mgfritch
approved these changes
Apr 24, 2023
Merged
14 tasks
adk3798
approved these changes
Apr 25, 2023
|
reruns of failed jobs: https://pulpito.ceph.com/adking-2023-05-01_11:51:02-orch:cephadm-wip-adk4-testing-2023-04-25-1313-pacific-distro-default-smithi/ After reruns, 4 failures:
Overall, nothing to block merging Notably for this PR, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/59237
backport of #49824
parent tracker: https://tracker.ceph.com/issues/58532
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh