Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: use deep-copy when setting permission during make_request #51188

Merged
merged 1 commit into from May 11, 2023
Merged

client: use deep-copy when setting permission during make_request #51188

merged 1 commit into from May 11, 2023

Conversation

Mer1997
Copy link
Contributor

@Mer1997 Mer1997 commented Apr 24, 2023 •
edited

We need MetaRequest's perms.gids keeps longer than syscal if mds reboot.
When mds reboot we need to rebuild MClientRequest with MetaRequest.

Fixes: https://tracker.ceph.com/issues/59514
Signed-off-by: Mer Xuanyi xuanyi.meng@xtaotech.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@github-actions github-actions bot added the cephfs Ceph File System label Apr 24, 2023
@vshankar vshankar requested a review from a team April 25, 2023 03:40
@vshankar
Copy link
Contributor

@Mer1997 Curious if you ran into an client side issue that prompted this change?

@Mer1997
Copy link
Contributor Author

Mer1997 commented Apr 25, 2023

@Mer1997 Curious if you ran into an client side issue that prompted this change?

Not really 😂, it's detected by address sanitizer.

vshankar
vshankar approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vshankar
Copy link
Contributor

@Mer1997 Please change commit message to "client: use deep-copy when setting permission during make_request".

@Mer1997
Copy link
Contributor Author

Mer1997 commented Apr 27, 2023

@Mer1997 Please change commit message to "client: use deep-copy when setting permission during make_request".

updated

@vshankar
Copy link
Contributor

jenkins test make check arm64

@vshankar vshankar changed the title client: use deep-copy here client: use deep-copy when setting permission during make_request Apr 27, 2023
@lxbsz
Copy link
Member

lxbsz commented Apr 28, 2023 •
edited

We need MetaRequest's perms.gids keeps longer than syscal if mds reboot. When mds reboot we need to rebuild MClientRequest with MetaRequest.

Fixes: https://tracker.ceph.com/issues/59514

LGTM.

BTW, could you update the commit comment by adding the above Fixes: .... ? Which will be easier to track the issue in future ?

Signed-off-by: Mer Xuanyi xuanyi.meng@xtaotech.com

@Mer1997
client: use deep-copy when setting permission during make_request
b88f50d 
We need MetaRequest's perms.gids keeps longer than syscal if mds reboot.
When mds reboot we need to rebuild MClientRequest with MetaRequest.

Fixes: https://tracker.ceph.com/issues/59514
Signed-off-by: Mer Xuanyi <xuanyi.meng@xtaotech.com>
@Mer1997
Copy link
Contributor Author

Mer1997 commented Apr 28, 2023 •
edited

We need MetaRequest's perms.gids keeps longer than syscal if mds reboot. When mds reboot we need to rebuild MClientRequest with MetaRequest.
Fixes: https://tracker.ceph.com/issues/59514

LGTM.

BTW, could you update the commit comment by adding the above Fixes: .... ? Which will be easier to track the issue in future ?

Signed-off-by: Mer Xuanyi xuanyi.meng@xtaotech.com

Ok 🤣, I just forget that before.

@Mer1997
Copy link
Contributor Author

Mer1997 commented May 2, 2023

jenkins test make check

lxbsz
lxbsz approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@lxbsz lxbsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vshankar
Copy link
Contributor

vshankar commented May 8, 2023

fs suite run: https://pulpito.ceph.com/vshankar-2023-05-08_02:52:50-fs-wip-vshankar-testing-20230507.032515-testing-default-smithi/

@vshankar
Copy link
Contributor

vshankar commented May 9, 2023

https://pulpito.ceph.com/vshankar-2023-05-09_07:29:33-fs-wip-vshankar-testing-20230509.054005-testing-default-smithi/

(after removing a problematic PR)

vshankar added a commit to vshankar/ceph that referenced this pull request May 10, 2023
@vshankar
Merge PR ceph#51188 into wip-vshankar-testing-20230510.034551
f2c3a77 
* refs/pull/51188/head:
	client: use deep-copy when setting permission during make_request

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
@vshankar
Copy link
Contributor

https://tracker.ceph.com/projects/cephfs/wiki/Main#11-May-2023

@vshankar vshankar merged commit 8151ff9 into ceph:main May 11, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vshankar vshankar vshankar approved these changes

@lxbsz lxbsz lxbsz approved these changes

Assignees
No one assigned
Labels
cephfs Ceph File System wip-vshankar-testing3
Projects
None yet
Milestone
No milestone
3 participants
@Mer1997 @vshankar @lxbsz