pacific: ceph-volume: fix drive-group issue that expects the batch_args to be a string #51209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The drive-group expects the batch_args to be a string, however in the current version it is passed as a list of one element, thus calling the first item of the list solves the issue. Fixes: https://tracker.ceph.com/issues/59203 Signed-off-by: Mohan Sharma <mohan7427@gmail.com> (cherry picked from commit 7602a99)
adk3798
approved these changes
Apr 25, 2023
|
reruns of failed jobs: https://pulpito.ceph.com/adking-2023-05-01_11:51:02-orch:cephadm-wip-adk4-testing-2023-04-25-1313-pacific-distro-default-smithi/ After reruns, 4 failures:
Overall, nothing to block merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/59256
backport of #49586
parent tracker: https://tracker.ceph.com/issues/59203
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh