quincy: mgr/cephadm: allow setting mon crush locations through mon service spec #51217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adk3798
force-pushed
the
wip-59547-quincy
branch
from
674c327
to
7f81cee
Compare
adk3798
commented
May 2, 2023
|
Reruns of failed/dead jobs: https://pulpito.ceph.com/adking-2023-05-22_14:09:29-orch:cephadm-wip-adk3-testing-2023-05-21-1607-quincy-distro-default-smithi/ After reruns, 2 failed, 1 dead job:
Overall, nothing to block merging |
…ns field In order to allow having cephadm set the crush locations for the mons. For helping with setting up stretch mode with a cephadm cluster Signed-off-by: Adam King <adking@redhat.com> (cherry picked from commit 416da86)
…n in spec Necessary to do this for stretch mode tiebreaker mon replacement Fixes: https://tracker.ceph.com/issues/58101 Signed-off-by: Adam King <adking@redhat.com> (cherry picked from commit ffec371)
Previously, the service config function was only called when we deploy a new daemon for that service. That meant that updates to the spec such as changing a cert that don't affect the daemon placement wouldn't trigger the service level config to happen again. With this change, we now mark the service as needing its config function ran if a daemon for the service is added/removed or if the spec is updated. Fixes: https://tracker.ceph.com/issues/58100 Signed-off-by: Adam King <adking@redhat.com> (cherry picked from commit 1d50a2c)
The part of this that added the --set-crush-location flag when deploying the mon was handled in another commit. This piece is to finish the functionality by having cephadm set the location through commands to handle when multiple bucket=loc pairs are specified for a single monitor Fixes: https://tracker.ceph.com/issues/58101 Signed-off-by: Adam King <adking@redhat.com> (cherry picked from commit 2672a71)
Trying to add a feature where mon crush locations can be set through the orchestrator using the mon service spec. This is meant to be a test for that. Signed-off-by: Adam King <adking@redhat.com> (cherry picked from commit 8c52a0a)
Signed-off-by: Adam King <adking@redhat.com> (cherry picked from commit cd96b70)
…tore
In a normal deployment, we generally shouldn't have
to worry about this. This is more for teuthology
which does deployments in a weird way that can cause
there to be no mon spec in the cluster. Fixes an issue
seen when backporting the mon crush location work
to quincy where an upgrade test would fail with
```
[WRN] UPGRADE_REDEPLOY_DAEMON: Upgrading daemon mon.b on host smithi047 failed.
Upgrade daemon: mon.b: Service mon not found.
```
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 8aab7be)
|
force pushed fixed a trivial merge conflict that was done the same way in the build used in the testing mentioned in my previous comment so no extra runs should be needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/59547
backport of #49103
parent tracker: https://tracker.ceph.com/issues/58101
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh