Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rgw/multisite[archive zone]: remove bucket metadata modification during object sync #51233

Merged
merged 1 commit into from May 25, 2023
Merged

rgw/multisite[archive zone]: remove bucket metadata modification during object sync #51233

merged 1 commit into from May 25, 2023

Conversation

smanjara
Copy link
Contributor

@smanjara smanjara commented Apr 26, 2023 •
edited

The bucket metadata changes sync as part of metadata sync already in
L2170 which was added to keep versioning on buckets enabled for archive_zone.
Besides, the put_bucket_instance_info() call here in sync_object() was resetting bucket attrs.

https://tracker.ceph.com/issues/61188

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

rgw/multisite: no need to enforce versioning on bucket during object …
2e7a8d8 
…sync on archive zone.

versioning is enforced as part of bucket metadata sync aready

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>
@smanjara smanjara requested a review from a team as a code owner April 26, 2023 14:34
@github-actions github-actions bot added the rgw label Apr 26, 2023
@smanjara
Copy link
Contributor Author

smanjara commented May 1, 2023

@cbodley could you review this one please?

@cbodley
Copy link
Contributor

cbodley commented May 25, 2023

passed qa after rerun https://pulpito.ceph.com/cbodley-2023-05-25_13:09:32-rgw-wip-cbodley-testing-distro-default-smithi/

@cbodley cbodley merged commit 20e5696 into ceph:main May 25, 2023
9 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbodley cbodley cbodley approved these changes

@yehudasa yehudasa Awaiting requested review from yehudasa

Assignees
No one assigned
Labels
needs-qa rgw wip-cbodley-testing
Projects
None yet
Milestone
No milestone
2 participants
@smanjara @cbodley