pacific: cmake: re-enable TCMalloc and allocator related cleanups #51282
Conversation
before this change, the ALLOCATOR cmake option are handled at two difference places: one to handle ALLOCATOR option, another to add compilation options based on ALLOCATOR. after this change: * the ALLOCATOR option is handled in a single place * dedup the branches handling different ALLOCATORS into a single condition: (NOT ALLOCATOR STREQUAL "libc") * add_compile_options() calls are consolidated into a single one Signed-off-by: Kefu Chai <tchaikov@gmail.com> (cherry picked from commit 677e134) Conflicts: CMakeLists.txt - Specify version 2.6.2 for gperftools package
before this change, we assume that "ALLOCATOR" is the library name which can be found by linker with "ld -l <namespec>". but ideally, cmake can find a library in a more sophiscated way used by its "find_library()" implementation. so, in this change, instead of relying on the default paths looked up by "ld", use the path found by cmake. Signed-off-by: Kefu Chai <tchaikov@gmail.com> Conflicts: cmake/modules/BuildFIO.cmake
to enable them to use the specified allocators Fixes: https://tracker.ceph.com/issues/55519 Signed-off-by: Kefu Chai <tchaikov@gmail.com>
|
jenkins test api |
|
@tchaikov Can you please take a look at this? I am hoping to get this into the possibly-last Pacific point release. |
|
Ping. Can this be looked at again? |
There was a problem hiding this comment.
@pponnuvel I built this patch and it is causing a build problem:
-- Found LZ4: /usr/lib/x86_64-linux-gnu/liblz4.so (found suitable version "1.7.1", minimum required is "1.7")
CMake Error at /usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
Could NOT find gperftools: Found unsuitable version "2.5", but required is
at least "2.6.2" (found /usr/include)
Call Stack (most recent call first):
/usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake:376 (_FPHSA_FAILURE_MESSAGE)
cmake/modules/Findgperftools.cmake:52 (find_package_handle_standard_args)
CMakeLists.txt:346 (find_package)
PTAL when you can. As Pacific is going EOL soon, we maybe should not include this.
|
@ljflores The gperftools version on Ubuntu/Bionic is 2.5, so obviously this fails to meet the minimum required version. Not using tcmalloc at all on Bionic defeats the purpose of this backport as the intention was to link with tcmalloc for performance reasons. I originally proposed this backport in light of https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/2016845. So I agree this isn't a critical issue for us in Ubuntu and can be closed since Pacific is going EOL anyway. Perhaps it's time to drop Ubuntu/Bionic (18.04) from https://docs.ceph.com/en/quincy/start/os-recommendations/#platforms so that Ubuntu/Bionic (18.04) need not be tested/built going forward. But that's a different discussion. |
backport tracker: https://tracker.ceph.com/issues/55541
backport of #46103
parent tracker: https://tracker.ceph.com/issues/55519
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh