mgr/dashboard: disable delete on multisite #51283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pegonzal
force-pushed
the
disable-delete
branch
from
160d756
to
d7d5bff
Compare
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
Pegonzal
requested review from
avanthakkar and
pereman2
and removed request for
a team
|
jenkins test make check |
Pegonzal
force-pushed
the
disable-delete
branch
2 times, most recently
from
4b642a9
to
04a34b4
Compare
|
jenkins test make check |
pereman2
requested changes
May 24, 2023
...dashboard/frontend/src/app/ceph/rgw/rgw-multisite-details/rgw-multisite-details.component.ts
Outdated
Show resolved
Hide resolved
...dashboard/frontend/src/app/ceph/rgw/rgw-multisite-details/rgw-multisite-details.component.ts
Outdated
Show resolved
Hide resolved
|
|
||
| if (node.data.type === 'zonegroup') { | ||
| if (this.zonegroups.length < 2) { | ||
| this.deleteTitle = 'You can not delete the only zonegroup available'; |
There was a problem hiding this comment.
I supposed this function would only return whether it is disabled or not. Maybe the return should be an empty string when it isn't disabled and a message of why is disabled if true.
...ph/rgw/models/rgw-multisite-zone-deletion-form/rgw-multisite-zone-deletion-form.component.ts
Outdated
Show resolved
Hide resolved
...ph/rgw/models/rgw-multisite-zone-deletion-form/rgw-multisite-zone-deletion-form.component.ts
Outdated
Show resolved
Hide resolved
|
jenkins test make check |
1 similar comment
|
jenkins test make check |
aaSharma14
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
Thank you @Pegonzal for the PR. Works as expected,tested locally. Can you please rebase the PR
pereman2
approved these changes
Jun 19, 2023
Fixes: https://tracker.ceph.com/issues/59441 Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
|
jenkins test dashboard |
|
jenkins test dashboard cephadm |
2 similar comments
|
jenkins test dashboard cephadm |
|
jenkins test dashboard cephadm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed shown pools to be deleted:
And disabled delete button on specified occasions where shouldn't be able to delete
Fixes: https://tracker.ceph.com/issues/59441
Signed-off-by: Pedro Gonzalez Gomez pegonzal@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows