pacific: common: Use double instead of long double to improve performance #51316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To convert namoseconds to seconds, the precision needs to be 10, and the precision of double is 15, which is enough to use. On aarch64, double division uses the div instruction, while long double uses the gcc buildin _divtf3, which has poor performance. Therefore, use double instead of long double for better performance. Signed-off-by: Chunsong Feng <fengchunsong@huawei.com> (cherry picked from commit 58753cf) Signed-off-by: luo rixin <luorixin@huawei.com>
|
jenkins retest this please |
|
@rosinL Any chance you have any performance or perf data showing an improvement (even cycles/op) for the change? |
|
Hi @markhpc, we have tested on aarch64, we get about 1% performance(IOPS) improvement for 4k randwrite. |
|
Sorry, I completely missed that this is just a backport. |
|
Can we merge this? @markhpc @rzarzynski |
rzarzynski
approved these changes
May 25, 2023
|
The main PR has been merged in 2021: #42082. |
|
@rosinL: one purely organization thing: may we get-or-create a ticket for tracing? |
I have added a backport tracker https://tracker.ceph.com/issues/61475. Would you help to update the tracker status? |
|
Switched https://tracker.ceph.com/issues/61475 to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To convert namoseconds to seconds, the precision needs to be 10, and the precision of double is 15, which is enough to use. On aarch64, double division uses the div instruction, while long double uses the gcc buildin _divtf3, which has poor performance. Therefore, use double instead of long double for better performance.
backport tracker: https://tracker.ceph.com/issues/61475
Signed-off-by: Chunsong Feng fengchunsong@huawei.com
Signed-off-by: luo rixin luorixin@huawei.com
(cherry picked from commit 58753cf)
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows