Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quincy: mgr: add urllib3==1.26.15 to mgr/requirements.txt #51335

Merged
merged 1 commit into from May 3, 2023

Conversation

ljflores
Copy link
Contributor

@ljflores ljflores commented May 3, 2023

backport tracker: https://tracker.ceph.com/issues/59625


backport of #51298
parent tracker: https://tracker.ceph.com/issues/59591

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh

We do not depend on any particular version of
urllib3, but as a workaround to the incompatibility
of urllib3 constraints between kubernetes and
requests, we need to pin it temporarily to
the version both are happy with.

Fixes: https://tracker.ceph.com/issues/59591
Signed-off-by: Laura Flores <lflores@redhat.com>
(cherry picked from commit 80d4600)
@ljflores ljflores added this to the quincy milestone May 3, 2023
@ljflores ljflores added the core label May 3, 2023
@ljflores ljflores requested review from dmick, adk3798 and cbodley May 3, 2023 14:21
Copy link
Contributor

@adk3798 adk3798 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

117/275 Test #2: setup-venv-for-mgr ........................ Passed 54.09 sec
seems to be working

Copy link
Contributor

@cbodley cbodley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ljflores ljflores merged commit 00daecb into ceph:quincy May 3, 2023
11 checks passed
@ljflores ljflores deleted the wip-59625-quincy branch May 3, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants