Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vstart: remove filestore options and config snippets #51362

Merged
merged 2 commits into from
May 19, 2023

Conversation

Svelar
Copy link
Member

@Svelar Svelar commented May 5, 2023

Remove filestore section from vstart.sh.

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

Signed-off-by: Rongqi Sun <sunrongqi@huawei.com>
@Svelar
Copy link
Member Author

Svelar commented May 8, 2023

Required checks passed, please review. @NitzanMordhai

src/vstart.sh Outdated Show resolved Hide resolved
Signed-off-by: Rongqi Sun <sunrongqi@huawei.com>
@idryomov idryomov requested a review from wjwithagen May 16, 2023 12:36
@idryomov idryomov changed the title Vstart: remove filestore section from vstart.sh vstart: remove filestore options and config snippets May 19, 2023
@idryomov idryomov merged commit 5fe9286 into ceph:main May 19, 2023
11 of 12 checks passed
@Svelar
Copy link
Member Author

Svelar commented May 19, 2023

@idryomov Thanks, can I cherry pick from commits then raise a backport PR to reef, or should I open a tracker first?

@idryomov
Copy link
Contributor

@idryomov Thanks, can I cherry pick from commits then raise a backport PR to reef, or should I open a tracker first?

No need for a ticket, just open a backport PR.

@Svelar
Copy link
Member Author

Svelar commented May 19, 2023

@idryomov Thanks, can I cherry pick from commits then raise a backport PR to reef, or should I open a tracker first?

No need for a ticket, just open a backport PR.

Done #51588 , check please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants