mds: wait migrate to finish when linking #51363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: https://tracker.ceph.com/issues/58340 Signed-off-by: Xiubo Li <xiubli@redhat.com>
When unlinking a remote dentry while primary dentry has been just unlinked and was trying to reintegrate, which will finally be a RENAME client request to current MDS, the stray dentry. If the RENAME request is sleeping and waiting for some resources just after authpin the CInode, so the unlinking request will mark the remote dentry as UNLINKING state and then add itself to the wait list just waiting for the CInode to be authpined. Then after the RENAME request is retried later it will add to a wait list again and waiting for the UNLINKING state to be cleared. And finally the RENAME and UNLINK requests will be deadlock. This fix will block the UNLINK request if the reintegrate_stray is going on for current dentry. Fixes: https://tracker.ceph.com/issues/58340 Signed-off-by: Xiubo Li <xiubli@redhat.com>
If the inode have 2 hard links and in two different MDSs. If the local dentry was unlinked and a new link request, which is trying to link a new dentry to this inode, comes, it will try to trigger to migrate the local stray denty to the remote MDS. This will cause deadlock because the link request will authpin the inode and keep waiting the migrating, which will also try to autopin the inode too, to finish. Fixes: https://tracker.ceph.com/issues/59657 Signed-off-by: Xiubo Li <xiubli@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the inode have 2 hard links and in two different MDSs. If the
local dentry was unlinked and a new link request, which is trying
to link a new dentry to this inode, comes, it will try to trigger
to migrate the local stray denty to the remote MDS.
This will cause deadlock because the link request will authpin
the inode and keep waiting the migrating, which will also try to
autopin the inode too, to finish.
Fixes: https://tracker.ceph.com/issues/59657
Signed-off-by: Xiubo Li xiubli@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows