RGW: add admin interfaces to get and delete notifications by bucket

[AliMasarweh]

RGW: add admin interfaces to get and delete notifications by bucket
https://tracker.ceph.com/issues/52980

Contribution Guidelines

• To sign and title your commits, please refer to Submitting Patches to Ceph.

• If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

Checklist

• Tracker (select at least one)
  • References tracker ticket
  • Very recent bug; references commit where it was introduced
  • New feature (ticket optional)
  • Doc update (no ticket needed)
  • Code cleanup (no ticket needed)
• Component impact
  • Affects Dashboard, opened tracker ticket
  • Affects Orchestrator, opened tracker ticket
  • No impact that needs to be tracked
• Documentation (select at least one)
  • Updates relevant documentation
  • No doc update is appropriate
• Tests (select at least one)
  • Includes unit test(s)
  • Includes integration test(s)
  • Includes bug reproducer
  • No tests

Show available Jenkins commands

• jenkins retest this please
• jenkins test classic perf
• jenkins test crimson perf
• jenkins test signed
• jenkins test make check
• jenkins test make check arm64
• jenkins test submodules
• jenkins test dashboard
• jenkins test dashboard cephadm
• jenkins test api
• jenkins test docs
• jenkins render docs
• jenkins test ceph-volume all
• jenkins test ceph-volume tox
• jenkins test windows

[yuvalif]

can you please paste sample outputs for the "get" and "list" commands?

[AliMasarweh]

[alimasa@folio11 build]$ bin/radosgw-admin notification list --bucket fish { "notifications": [ { "TopicArn": "arn:aws:sns:default::fishtopic", "Id": "notif1", "Events": [ "s3:ObjectCreated:*", "s3:ObjectRemoved:*" ], "Filter": { "S3Key": {}, "S3Metadata": {}, "S3Tags": {} } } ] } [alimasa@folio11 build]$ bin/radosgw-admin notification get --notification-id notif1 --bucket fish { "TopicArn": "arn:aws:sns:default::fishtopic", "Id": "notif1", "Events": [ "s3:ObjectCreated:*", "s3:ObjectRemoved:*" ], "Filter": { "S3Key": {}, "S3Metadata": {}, "S3Tags": {} } }
outputs for the "get" and "list" commands

[yuvalif]

please make sure that you update: src/test/cli/radosgw-admin/help.t with the changes to radosgw-admin --help

[yuvalif]

please add integration test.
please look at: src/test/rgw/bucket_notification/test_bn.py at the test_ps_s3_topic_admin_on_master() function and create a similar function for the notifications CLI

[yuvalif]

when bucket-id parameter is not provided to radosgw-admin notification rm we get the following error message:

ERROR: could not init bucket: 2023-05-14T10:23:58.847+0000 7f2d253dd780  0 ERROR: obj.oid is empty

instead of an error message stating that the bucket-id parameter is missing.
similar to what we receive we calling "notification get/list" without a bucket:

ERROR: bucket name was not provided (via --bucket)

[AliMasarweh]

teuthology run:
http://pulpito.front.sepia.ceph.com/alimasa-2023-05-29_11:22:57-rgw:notifications-wip-alimasa-topics-op-by-bucket-distro-default-smithi/