Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pacific: os/bluestore: allow 'fit_to_fast' selector for single-volume osd #51418

Merged
merged 1 commit into from Aug 15, 2023

Conversation

ifed01
Copy link
Contributor

@ifed01 ifed01 commented May 10, 2023

backport of #50095

backport tracker: https://tracker.ceph.com/issues/59338
parent tracker: https://tracker.ceph.com/issues/57855

Signed-off-by: Igor Fedotov igor.fedotov@croit.io
(cherry picked from commit 25c8df3)

Conflicts:
src/os/bluestore/BlueStore.cc
Missing backport
Conflicts:
src/os/bluestore/BlueStore.cc
lacking another backport

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

Fixes: https://tracker.ceph.com/issues/57855

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit 25c8df3)

 Conflicts:
	src/os/bluestore/BlueStore.cc
 lacking another backport
@ifed01 ifed01 requested a review from a team as a code owner May 10, 2023 07:50
@ifed01 ifed01 requested a review from aclamk May 10, 2023 07:51
@github-actions github-actions bot added this to the pacific milestone May 10, 2023
@sseshasa
Copy link
Contributor

sseshasa commented Aug 1, 2023

@ifed01 The following teuthology ObjectStore test https://pulpito.ceph.com/yuriw-2023-07-27_22:37:12-rados-wip-yuri6-testing-2023-07-24-0819-pacific-distro-default-smithi/7354890 failed.

The following tests failed: ObjectStore/StoreTestSpecificAUSize.SpilloverFixedTest and
ObjectStore/StoreTestSpecificAUSize.SpilloverFixed2Test. Can you please check and confirm if the failure is related to this PR?

I will remove the relevant test tag and 'needs-qa' label for now. Please add the 'needs-qa' label back once the PR is ready for a re-test.

Alternatively, if the failure is unrelated, a new tracker may be raised for the above failure and this PR may be merged. Please update accordingly.

@ifed01
Copy link
Contributor Author

ifed01 commented Aug 2, 2023

@sseshasa - I updated test cases in #51773 which is apparently a culprit for the teuthology failures. So both this PR and #51773 are ready for another QA round

@ifed01 ifed01 added the needs-qa label Aug 2, 2023
@sseshasa
Copy link
Contributor

sseshasa commented Aug 3, 2023

@sseshasa - I updated test cases in #51773 which is apparently a culprit for the teuthology failures. So both this PR and #51773 are ready for another QA round

@ifed01 Sure, this and #51773 will go through another QA round.

@ljflores
Copy link
Contributor

@yuriw yuriw merged commit c588a62 into ceph:pacific Aug 15, 2023
8 checks passed
@ifed01 ifed01 deleted the wip-ifed-fix-fit-to-fast-pac branch August 16, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants