New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc/cephfs: fix prompts in fs-volumes.rst #51427
Merged
zdover23
merged 1 commit into
ceph:main
from
zdover23:wip-doc-2023-05-10-cephfs-fs-volumes-prompt-fix
May 10, 2023
Merged
doc/cephfs: fix prompts in fs-volumes.rst #51427
zdover23
merged 1 commit into
ceph:main
from
zdover23:wip-doc-2023-05-10-cephfs-fs-volumes-prompt-fix
May 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a regression introduced in e5355e3 that broke the unselectable prompts in the RST. Signed-off-by: Zac Dover <zac.dover@proton.me>
zdover23
force-pushed
the
wip-doc-2023-05-10-cephfs-fs-volumes-prompt-fix
branch
from
May 10, 2023 15:10
e26c725
to
e019948
Compare
colemitchell
approved these changes
May 10, 2023
zdover23
added a commit
to zdover23/ceph
that referenced
this pull request
May 12, 2023
Make sure all prompts are unselectable. This PR is meant to be backported to Reef, Quincy, and Pacific, to get all of the prompts into a fit state so that a line-edit can be performed on the Englsh language in this file. Follows ceph#51427. Signed-off-by: Zac Dover <zac.dover@proton.me>
14 tasks
zdover23
added a commit
to zdover23/ceph
that referenced
this pull request
May 12, 2023
Make sure all prompts are unselectable. This PR is meant to be backported to Reef, Quincy, and Pacific, to get all of the prompts into a fit state so that a line-edit can be performed on the Englsh language in this file. Follows ceph#51427. Signed-off-by: Zac Dover <zac.dover@proton.me> (cherry picked from commit 1f88f10)
zdover23
added a commit
to zdover23/ceph
that referenced
this pull request
May 12, 2023
Make sure all prompts are unselectable. This PR is meant to be backported to Reef, Quincy, and Pacific, to get all of the prompts into a fit state so that a line-edit can be performed on the Englsh language in this file. Follows ceph#51427. Signed-off-by: Zac Dover <zac.dover@proton.me> (cherry picked from commit 1f88f10)
This was referenced May 12, 2023
zdover23
added a commit
to zdover23/ceph
that referenced
this pull request
May 12, 2023
Make sure all prompts are unselectable. This PR is meant to be backported to Reef, Quincy, and Pacific, to get all of the prompts into a fit state so that a line-edit can be performed on the Englsh language in this file. Follows ceph#51427. Signed-off-by: Zac Dover <zac.dover@proton.me> (cherry picked from commit 1f88f10)
zdover23
added a commit
to zdover23/ceph
that referenced
this pull request
May 12, 2023
Make sure all prompts are unselectable. This PR is meant to be backported to Reef, Quincy, and Pacific, to get all of the prompts into a fit state so that a line-edit can be performed on the Englsh language in this file. Follows ceph#51427. Signed-off-by: Zac Dover <zac.dover@proton.me> (cherry picked from commit 1f88f10)
14 tasks
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a regression introduced in
e5355e3 that broke the unselectable prompts in the RST.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows