pacific: librbd: localize snap_remove op for mirror snapshots #51431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be rebased: includes #51429 to avoid further conflicts. |
I would make this really obvious by basing directly on wip-59506-pacific branch -- so that SHA1s are same. |
chrisphoffman
force-pushed
the
wip-59710-pacific
branch
from
7e7a666
to
554d0c2
Compare
idryomov
approved these changes
May 17, 2023
14 tasks
|
@chrisphoffman This was tested and ready for merge skipping merge because of |
A client may attempt a lock request not quickly enough to obtain exclusive lock for operations when another competing client responds quicker. This can happen when a peer site has different performance characteristics or latency. Instead of relying on this unpredictable behavior, localize operation to primary cluster. Fixes: https://tracker.ceph.com/issues/59393 Signed-off-by: Christopher Hoffman <choffman@redhat.com> (cherry picked from commit ac552c9) Conflicts: src/cls/rbd/cls_rbd.cc [ commit 3a93b40 ("librbd: s/boost::variant/std::variant/") not in pacific ] src/librbd/mirror/snapshot/UnlinkPeerRequest.cc [ ditto ]
chrisphoffman
force-pushed
the
wip-59710-pacific
branch
from
554d0c2
to
3885255
Compare
Now done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/59710
backport of #51166
parent tracker: https://tracker.ceph.com/issues/59393
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh