Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quincy: mds: do not take the ino which has been used #51507

Merged
merged 3 commits into from Jun 15, 2023
Merged

quincy: mds: do not take the ino which has been used #51507

merged 3 commits into from Jun 15, 2023

Conversation

lxbsz
Copy link
Member

@lxbsz lxbsz commented May 16, 2023 •
edited by mchangir

backport tracker: https://tracker.ceph.com/issues/59707

backport of #43184
parent tracker: https://tracker.ceph.com/issues/52280

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@lxbsz lxbsz requested a review from a team May 16, 2023 05:53
@lxbsz lxbsz requested a review from a team as a code owner May 16, 2023 05:53
@github-actions github-actions bot added this to the quincy milestone May 16, 2023
@lxbsz
Copy link
Member Author

lxbsz commented May 16, 2023

This will depend on #50724 and need to rebase after #50724 gets merged.

@vshankar
Copy link
Contributor

jenkins test windows

@vshankar
Copy link
Contributor

jenkins test windows

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

lxbsz added 3 commits June 9, 2023 10:01
@lxbsz
mds: do not take the ino which has been used
3d420af 
When replaying the journals, if the inodetable or the sessionmap
versions do not match, the CInode will be added to the inode_map,
but the ino may still be in the inodetable or sessions' prealloc
inos list.

So when allocating new CInode we should skip them.

Fixes: https://tracker.ceph.com/issues/52280
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit a8c63c7)
@lxbsz
qa: add test support for the alloc ino failing
aee6f6b 
Fixes: https://tracker.ceph.com/issues/52280
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 7179709)
@lxbsz
qa: fix journal flush failure issue due to the MDS daemon crashes
7c3642a 
After the MDS daemon crashing, the journal flush request will fail.

Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit d851a94)
@lxbsz
Copy link
Member Author

lxbsz commented Jun 9, 2023

This will depend on #50724 and need to rebase after #50724 gets merged.

Since the #50724 has been merged, rebase to the upstream.

@mchangir
Copy link
Contributor

jenkins test api

mchangir
mchangir approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@mchangir mchangir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuriw yuriw merged commit 35b9a81 into ceph:quincy Jun 15, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchangir mchangir mchangir approved these changes

Assignees
No one assigned
Labels
cephfs Ceph File System common documentation needs-qa tests wip-yuri3-testing
Projects
None yet
Milestone
quincy
4 participants
@lxbsz @vshankar @mchangir @yuriw