Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pacific: mds: do not take the ino which has been used #51508

Merged
merged 3 commits into from Aug 8, 2023

Conversation

lxbsz
Copy link
Member

@lxbsz lxbsz commented May 16, 2023

backport tracker: https://tracker.ceph.com/issues/59706


backport of #43184
parent tracker: https://tracker.ceph.com/issues/52280

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@lxbsz lxbsz requested a review from a team May 16, 2023 06:09
@lxbsz lxbsz requested a review from a team as a code owner May 16, 2023 06:09
@github-actions github-actions bot added this to the pacific milestone May 16, 2023
@gregsfortytwo
Copy link
Member

@lxbsz this backport is broken because in Pacific you can't access config values directly unless they're part of legacy_config_opts.h.

When replaying the journals, if the inodetable or the sessionmap
versions do not match, the CInode will be added to the inode_map,
but the ino may still be in the inodetable or sessions' prealloc
inos list.

So when allocating new CInode we should skip them.

Fixes: https://tracker.ceph.com/issues/52280
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit a8c63c7)
Fixes: https://tracker.ceph.com/issues/52280
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 7179709)

 Conflicts:
	doc/cephfs/mds-config-ref.rst: format changed
	src/common/options/mds.yaml.in: no such file
After the MDS daemon crashing, the journal flush request will fail.

Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit d851a94)
@lxbsz
Copy link
Member Author

lxbsz commented Jun 15, 2023

@lxbsz this backport is broken because in Pacific you can't access config values directly unless they're part of legacy_config_opts.h.

Fixed it.

Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuriw yuriw merged commit 4273db0 into ceph:pacific Aug 8, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants